Fix #79551 #79566
Merged
Fix #79551 #79566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Refactor debug file management by replacing destructor call with explicit deinitialization method
github-actions
bot
added
[C++]
moxian
reviewed
Feb 6, 2025
github-actions
bot
added
the
BasicBuildPassed
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
github-actions
bot
added
astyled
moxian
approved these changes
Feb 7, 2025
github-actions
bot
added
BasicBuildPassed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Bugfixes "#79551 Crash calling destructor twice"
Purpose of change
Rename the destructor to deinit.
Describe the solution
Avoid calling manually this destructor because it will called again at program exit and try to deallocate internal components on the heap twice.
Describe alternatives you've considered
Testing
✔ Tested on WSL/Ubuntu and Windows
Additional context