Fixed raw return propoerties of WriteSingleRegisterClient

+ extended the test to catch the bug
Cloud-Automation · Nov 22, 2016 · 40530e7 · 40530e7
1 parent 731a704
commit 40530e7
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/src/handler/client/WriteSingleRegister.js b/src/handler/client/WriteSingleRegister.js
@@ -22,8 +22,8 @@ module.exports = Stampit()
                 fc              : fc,
                 registerAddress : registerAddress,
                 registerValue   : registerValue,
-                registerAddressRaw: pdu.slice(1,2),
-                registerValueRaw: pdu.slice(3,2)
+                registerAddressRaw: pdu.slice(1,3),
+                registerValueRaw: pdu.slice(3,5)
             };
 
             if (fc !== 6) {

diff --git a/test/modbus-client-core.test.js b/test/modbus-client-core.test.js
@@ -320,7 +320,9 @@ describe("Modbus Serial Client", function () {
 
                 assert.equal(resp.fc, 6);
                 assert.equal(resp.registerAddress, 3);
+                assert.deepEqual(resp.registerAddressRaw, Buffer.from([0x00,0x03]));
                 assert.equal(resp.registerValue, 123);
+                assert.deepEqual(resp.registerValueRaw, Buffer.from([0x00,0x7b]));
 
                 done();
 
@@ -349,6 +351,8 @@ describe("Modbus Serial Client", function () {
                 assert.equal(resp.fc, 6);
                 assert.equal(resp.registerAddress, 3);
                 assert.equal(resp.registerValue, 123);
+                assert.deepEqual(resp.registerAddressRaw, Buffer.from([0x00,0x03]));
+                assert.deepEqual(resp.registerValueRaw, Buffer.from([0x00,0x7b]));
 
                 done();