Added listener to exit process when db connection fails #1752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anandkumarpatel
requested changes
Oct 7, 2016
lib/models/mongo/mongoose-control.js
Outdated
| @@ -52,6 +52,19 @@ mongooseControl.start = function (cb) { | |||
| } | |||
|
|
|||
| mongoose.connect(process.env.MONGO, mongooseOptions, cb) | |||
| mongoose.connection.on('disconnected', function () { | |||
There was a problem hiding this comment.
nice, to clean this up a bit can you move this to a helper function?
mongooseControl._handleDisconnect()
uncle bob and I would also be very happy if you broke that down further into
mongooseControl._exitIfNotOpened() {...}
mongooseControl._exitIfConnectionNeverMade () {...}
anandkumarpatel
requested changes
Oct 10, 2016
lib/models/mongo/mongoose-control.js
Outdated
| @@ -63,3 +71,17 @@ mongooseControl.stop = function (cb) { | |||
| }) | |||
| }) | |||
| } | |||
|
|
|||
| mongooseControl._exitIfFailedToOpen = function () { | |||
| log.fatal({message: 'Failed to connect to ' + process.env.MONGO}, 'failed to establish a connection to mongodb') | |||
There was a problem hiding this comment.
nit: you dont need message,
log.fatal(Failed to connect to ${process.env.MONGO} failed to establish a connection to mongodb)
lib/models/mongo/mongoose-control.js
Outdated
| } | ||
|
|
||
| mongooseControl._exitIfFailedToReconnect = function() { | ||
| log.error({message: 'Lost connection to ' + process.env.MONGO}) |
lib/models/mongo/mongoose-control.js
Outdated
| mongooseControl._exitIfFailedToReconnect = function() { | ||
| log.error({message: 'Lost connection to ' + process.env.MONGO}) | ||
| setTimeout(function () { | ||
| if (!mongoose.connection.readyState) { |
There was a problem hiding this comment.
lets add log here as well
| @@ -103,5 +103,34 @@ describe('mongoose-control', function () { | |||
| done() | |||
| }) | |||
| }) | |||
|
|
|||
| describe('handling mongodb disconnect events', function () { | |||
There was a problem hiding this comment.
add unit test for _exitIfFailedToReconnect and _exitIfFailedToOpen please.
you can use sinon to mock timers as well.
henrymollman
force-pushed
the
shutdown-api-on-db-disconnect
branch
from
fe7541a to
bfa69b9
Compare
henrymollman
force-pushed
the
shutdown-api-on-db-disconnect
branch
from
643c43b to
a96af0e
Compare
anandkumarpatel
requested changes
Oct 11, 2016
configs/.env.staging
Outdated
| @@ -3,6 +3,7 @@ AWS_ACCESS_KEY_ID=AKIAJXF6CNCWBWNX7JZQ | |||
| AWS_SECRET_ACCESS_KEY=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 | |||
| BUNYAN_BATCH_LOG_COUNT=5 | |||
| DATADOG_HOST=datadog-staging-codenow.runnableapp.com | |||
| DB_CONNECTION_TIMEOUT=10000 | |||
There was a problem hiding this comment.
if values are the same across env's you should put them in the .env file which is shared by all env's
anandkumarpatel
approved these changes
Oct 12, 2016
podviaznikov
approved these changes
Dec 23, 2016
|
@henrymollman can we merge this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added disconnect listener on the mongoose db connector to exit the node process when the db fails to connect on startup or disconnects while api is running and does not reconnect in 10 seconds.
To test, API must be run with