Everyone can use local dev #1902
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
don't use csrf if running locally
Myztiq
reviewed
Mar 2, 2017
configs/.env.development
Outdated
| @@ -1,27 +1,43 @@ | |||
| ASSERT_HTTPS=false | |||
| AWS_ACCESS_KEY_ID=AKIAJXF6CNCWBWNX7JZQ | |||
| AWS_SECRET_ACCESS_KEY=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 | |||
| AWS_ACCESS_KEY_ID=AKIAIDC4WVMTCGV7KRVQ | |||
Myztiq
reviewed
Mar 2, 2017
configs/.env.development
Outdated
| GITHUB_DEPLOY_KEYS_POOL_SIZE=10 | ||
| GITHUB_DEPLOY_KEY_TITLE=Runnable-development | ||
| GITHUB_HOOK_SECRET=3V3RYTHINGisAW3S0ME! | ||
| KRAIN_PORT=3100 | ||
| LOG_SRC=true | ||
| MONGO=mongodb://127.0.0.1:27017/runnable2 | ||
| MONGO=mongodb://api:3f5210b8-8fe3-11e5-8e62-07b6eff19ecb@127.0.0.1:27020/gamma |
There was a problem hiding this comment.
Nope. Don't encode production data in here. If we need to, we need to read it from devops-scripts.
There was a problem hiding this comment.
How do we do that, but make it automatic for people?
This will suck for everyone, but maybe someone will be motivated to fix it
Myztiq
reviewed
Mar 2, 2017
configs/.env.development
Outdated
| RABBITMQ_PASSWORD=guest | ||
| RABBITMQ_USERNAME=guest | ||
| REDIS_IPADDRESS=127.0.0.1 | ||
| REDIS_PORT=6379 | ||
| S3_CONTEXT_RESOURCE_BUCKET=runnable.context.resources.development | ||
| S3_CONTEXT_RESOURCE_BUCKET=runnable.context.resources.production-gamma | ||
| SENDGRID_KEY=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 |
Myztiq
approved these changes
Mar 2, 2017
anandkumarpatel
requested changes
Jun 20, 2017
| GITHUB_DEPLOY_KEYS_POOL_SIZE=10 | ||
| GITHUB_DEPLOY_KEY_TITLE=Runnable-development | ||
| GITHUB_HOOK_SECRET=3V3RYTHINGisAW3S0ME! | ||
| KRAIN_PORT=3100 | ||
| LOG_SRC=true | ||
| MONGO=mongodb://127.0.0.1:27017/runnable2 | ||
| MONGO=mongodb://api:[REPLACEME]@127.0.0.1:27020/gamma |
There was a problem hiding this comment.
This is jank, if you need to set this manually, just set it locally when you develop. should not be in repo
|
@Nathan219 do you still want this? |
|
I say lets make this in compose rather then in this file maybe? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Come on everybody!