Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITP_JAN_25 / YORSALEM MESMER / Module-Onboarding / Week 1 #222

Closed
wants to merge 10 commits into from
Closed

ITP_JAN_25 / YORSALEM MESMER / Module-Onboarding / Week 1 #222

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
01ac17c
chenge title
Jerry-yorsalem Jan 18, 2025
c68780b
I made some chenges on css
Jerry-yorsalem Jan 28, 2025
052c241
Add structure on Html
Jerry-yorsalem Jan 28, 2025
b0dbece
Change img
Jerry-yorsalem Jan 28, 2025
bca8756
I have made all recommendation
Jerry-yorsalem Jan 28, 2025
565f69b
I change the url file to a descriptive text inside the alt attribute.
Jerry-yorsalem Jan 29, 2025
9fd6c1e
I add a background colour to the footer.
Jerry-yorsalem Jan 29, 2025
62da588
I added a link to the Read more.
Jerry-yorsalem Jan 29, 2025
dd9904e
I removed div from html file to fix my accessibility score.
Jerry-yorsalem Jan 30, 2025
fbbb9f4
The inspect outcome of lighthouse is 100%
Jerry-yorsalem Jan 30, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Wireframe/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ main {
margin: auto;
}
footer {
background-color: rgb(184, 134, 249);
position: fixed;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as best practice footers are generally stretched to its container, this is a design enhancement, you don't have to do it, but it is better to practice more which will improve your UI and UX skills

bottom: 0;
text-align: center;
Expand Down