offer theme #1236
Merged
offer theme #1236
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rm import fix improper li nesting break counts apparently
feel free to move around/rename
I can imagine wanting a "reviews" dashboard that displays broader information in the future, e.g. things that have been reviewed.
illicitonion
force-pushed
the
theme-dashboard
branch
from
b55203f to
6c19fba
Compare
1. move selection to [data-attributes] 1. mark up with BEM
illicitonion
approved these changes
Dec 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(i had broken the count in the summary divs but now I fixed)
things i changed
I moved the scripts into the assets file so they can be piped
I made a default layout
I fixed all the broken HTML
I added a very cursory BEM, we would improve this later
I fixed the improper nesting of the list items
Then I realised I'd broken the counts so I dropped your divs back in until we can do a nice/polishing pass