DX: identify unidentified variables in notebooks #223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
This was referenced Dec 6, 2023
auto-merge was automatically disabled
December 9, 2023 00:59
Pull request was closed
redeboer
added a commit
that referenced
this pull request
Dec 9, 2023
* DX: gitignore `.jupyter_ystore.db` This is a file produced by `jupyter-collaboration` * DX: gitignore `oryx-build-commands.txt` Produced when running on GitHub Codespaces * DX: identify unidentified variables in notebooks (#223) * MAINT: clean up `conf.py` with new Sphinx extensions * MAINT: remove `ypy-websocket` version constraints --------- Co-authored-by: GitHub <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruff was ignoring
F821in Jupyter notebooks. This is not a good idea, because one often makes typos and then only realizes that a variable name is mistyped only once the notebook is run. Now, typos in variable names are flagged.The reason for ignoring
F821is that cell magic sometimes makes it look like a variable is not defined, which resulted in many false-positives. There is no good solution for this, so the error is now ignored for specific notebooks.