Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: build amplitude with K-matrix dynamics #278

Merged
merged 92 commits into from
May 24, 2024
Merged

DOC: build amplitude with K-matrix dynamics #278

merged 92 commits into from
May 24, 2024

Conversation

Zeyna777
Copy link
Contributor

@Zeyna777 Zeyna777 commented May 22, 2024 •
edited by redeboer
Loading

Imported some more notebooks from https://github.com/ComPWA/K-matrix-research/pull/72. See also #261.

Notebook Topic
TR-030 Sub-intensity plots and phases
TR-031 Fit comparison P vector and Breit–Wigner
TR-032 Coupled P vector fit

To do
Preview Give feedback

@Zeyna777 Zeyna777 added the ✨ Feature New feature added to the package label May 22, 2024
@Zeyna777 Zeyna777 added this to the 0.0.2 milestone May 22, 2024
@Zeyna777 Zeyna777 requested a review from redeboer May 22, 2024 11:24
@review-notebook-app Review Notebook App
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@Zeyna777 Zeyna777 changed the title ImportNotbooksfromKmatrix feat: import notbooks from kmatrix May 22, 2024
@Zeyna777 Zeyna777 removed this from the 0.0.2 milestone May 22, 2024
@Zeyna777 Zeyna777 changed the title feat: import notbooks from kmatrix FEAT: import notbooks from kmatrix May 22, 2024
@Zeyna777 Zeyna777 requested review from redeboer and removed request for redeboer May 22, 2024 11:29
@redeboer redeboer changed the title FEAT: import notbooks from kmatrix DOC: build amplitude with K-matrix dynamics May 22, 2024
@redeboer

This comment was marked as resolved.

Sign in to view
Lena Poepping and others added 17 commits May 23, 2024 15:57
@redeboer
DOC: import notebooks from https://github.com/ComPWA/K-matrix-research
71c5e3f
@pre-commit-ci @redeboer
[pre-commit.ci] auto fixes from pre-commit.com hooks
40d11cf 
for more information, see https://pre-commit.ci
@redeboer
MAINT: update Python version in kernel
e018711
@redeboer
MAINT: address Ruff linting issues
2005d2b
@redeboer
MAINT: move import statements to top
b5df13a
@redeboer
DOC: integrate notebooks into TR infrastructure
683b239
@redeboer
FIX: import create_dynamics_symbol() from K-matrix-research
526c4f4 
This makes the notebooks standalone, as the `kmatrix` package has not been published
@redeboer
FIX: import additional nstar definitions
3718df9
@redeboer
MAINT: rename additional-definitions.yml
8f0529a
@redeboer
DOC: fix cspell errors
b6e7c20
@redeboer
FIX: install jax and phasespace
0a561e1
@redeboer
FIX: make notebooks runnable
eb98b66
@redeboer
DOC: improve fake Nstar names
e34a211
@redeboer
ENH: use JAX as backend
bd0cedf
@redeboer
BEHAVIOR: generate data with F-vector instead of BW
80c0466
@redeboer
DOC: remove N* tables
49d349f
@redeboer
MAINT: remove slideshow and editable notebook metadata
0437e1b
redeboer added 25 commits May 24, 2024 11:38
@redeboer
MAINT: simplify evaluate() of ChewMandelstam
bc3a2ea
@redeboer
ENH: simplify LaTeX name of fake N* resonances
0117fc8
@redeboer
ENH: render particle name with unicode subscript
b818a0a
@redeboer
MAINT: move expression unfolding to numerical function generation
3bff6b4
@redeboer
ENH: define estimator sum with comprehension
99af9f5
@redeboer
ENH: remove redundant display statements
290cded
@redeboer
ENH(TR-032): compute histograms with JAX
8e8960c
@redeboer
MAINT(TR-032): equalize notebook style with TR-031
14daa27
@redeboer
ENH: improve sub-section orderin in fit section
ee34514
@redeboer
ENH(TR-032): remove CSVSummary callback
42eefdf
@redeboer
DX(TR-032): assert if fit succeeded
1b0a15d
@redeboer
MAINT(TR-032): use list comprehensions
4dfb58f
@redeboer
FIX(TR-032): remove redundant DataFrame call
6afb6ea
@redeboer
FIX(TR-032): remove m_0 etc from default parameters
eaad1d2
@redeboer
MAINT(TR-032): remove redundant DYNAMICS_FUNCS_FVECTOR
00d2280
@redeboer
DOC(TR-032): improve section organization "Generate data"
665493d
@redeboer
MAINT(TR-032): rename epsilon to ε
56495fb
@redeboer
ENH(TR-032): set original parameters just before data generation
77df570
@redeboer
DOC(TR-032): indicate thresholds in toy model parameter plot
6bbc48b
@redeboer
ENH(TR-032): improve coupling values for clearer Flatté effect
85c6358
@redeboer
ENH(TR-032): combine parameter comparison plot in one figure
35c7554
@redeboer
DOC: improve HTML rendering
dd57957
@redeboer
MAINT: rename new_parameters to toy_parameters
3e2649a
@redeboer
MAINT: update notebook kernels of affected notebooks
d8f3684
@redeboer
FIX: do not fit beta in coupled fit
1bf0249
@redeboer redeboer enabled auto-merge (squash) May 24, 2024 15:00
redeboer
redeboer approved these changes May 24, 2024
View reviewed changes
Copy link
Member

@redeboer redeboer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥐

@redeboer redeboer merged commit 7dacea5 into main May 24, 2024
11 checks passed
@redeboer redeboer deleted the kmatrix branch May 24, 2024 15:43
@redeboer redeboer mentioned this pull request Oct 1, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@redeboer redeboer redeboer approved these changes

Assignees

@redeboer redeboer

@Zeyna777 Zeyna777

Labels
✨ Feature New feature added to the package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zeyna777 @redeboer