Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New navigation structure #2211

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

New navigation structure #2211

wants to merge 61 commits into from

Conversation

maiwald
Copy link
Collaborator

@maiwald maiwald commented Oct 11, 2024

This PR adds the app layout proposed by Shapefield's redesign.

@github-actions GitHub Actions
Copy link

LCOV of commit c79d219 during Continuous Integration #3990

Summary coverage rate:
  lines......: 65.5% (14012 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 24d5006 during Continuous Integration #4002

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 2 times, most recently from c7987e5 to 7aef24f Compare October 15, 2024 15:16
@github-actions GitHub Actions
Copy link

LCOV of commit c7987e5 during Continuous Integration #4013

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 7aef24f during Continuous Integration #4014

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 873dd7d during Continuous Integration #4021

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 3ff6333 during Continuous Integration #4023

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 5 times, most recently from 7791446 to e7dd4d4 Compare October 17, 2024 14:11
@maiwald maiwald changed the base branch from update-bootstrap-ui-library to main October 18, 2024 08:57
@github-actions GitHub Actions
Copy link

LCOV of commit 2b81966 during Continuous Integration #4044

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 3 times, most recently from af52890 to 7d91b52 Compare October 28, 2024 13:41
@github-actions GitHub Actions
Copy link

LCOV of commit af52890 during Continuous Integration #4058

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 7d91b52 during Continuous Integration #4059

Summary coverage rate:
  lines......: 65.5% (14026 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@github-actions GitHub Actions
Copy link

LCOV of commit 9c65396 during Continuous Integration #4061

Summary coverage rate:
  lines......: 65.5% (14011 of 21399 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

@maiwald maiwald force-pushed the new-navigation-structure branch 2 times, most recently from 6ed7199 to 26741fb Compare October 29, 2024 10:37
@github-actions GitHub Actions
Copy link

LCOV of commit 26741fb during Continuous Integration #4064

Summary coverage rate:
  lines......: 65.5% (14010 of 21400 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

JoachimTillessen and others added 28 commits November 15, 2024 08:53
@JoachimTillessen @maiwald
improve styling for sidebar
8edc8af
@JoachimTillessen @maiwald
visually align support and user menu
94d6379
@maiwald
Highlight selected collection group with collapsed sidebar
b5c74e0
@maiwald
Consolidate Admin, CnC & Home Navigation components
c4b8b05
@JoachimTillessen @maiwald
Fix spacing in collection tree
962737a
@JoachimTillessen @maiwald
Replace expand icon in collection tree
03e7c1e
@maiwald
Move ExportImportButton sub-components into subfolders
ce8092a
@maiwald
Add styleguide stub
208ca9f
@JoachimTillessen @maiwald
add typeface and color scheme for buttons
6b1fe9f
@JoachimTillessen @maiwald
fix naming font files
8d7d65a
@JoachimTillessen @maiwald
implement sheets and sheet-tabs
d708420
@JoachimTillessen @maiwald
Make content readable with new bg color
efc9d1e
@maiwald
Remove full screen mode
69f243c
@maiwald
Add listView/detailView panel resizing
ed6c2dd
@JoachimTillessen @maiwald
apply design changes to rebased code
c4aaeba
@JoachimTillessen @maiwald
Style resize handle
20ade97
@JoachimTillessen @maiwald
Remove scss file extension from import statement
61237fa
@JoachimTillessen @maiwald
Change input bg color, update styleguide
2bc9d9c
@JoachimTillessen @maiwald
Change input bg color for selects and checkboxes
7211fd1
@JoachimTillessen @maiwald
apply paper color to numerous elements
c9ca688
@maiwald
Fix additional popover Header breaking rounded border
5615463 
The first <Popover.Header> is not the first DOM node in the <Popover>.
React bootstrap prepends another element for the arrow, so :first-child
does not work here.

I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)`
but I suppose our css preprocessor does not support the relatively new
nth-of selector, because the selector is mangled in the compiled output.

https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
@maiwald
Rework tab layout editing to proper drag and drop
14923ba 
This patch introduces the TabLayoutEditor component with a
drag-and-drop interface for reordering and hiding/showing tabs.

The component accepts an ItemComponent via the `getItemComponent` prop
for rendering individual items.

With this patch we no longer need to manage the synthetic 'hidden' Tab
when no tabs are currently hidden. This is now the editor component's
responsibility and using code does not have to manage that.

This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a
unique scope for each instance of the editor, because drag-and-drop is
only supposed to work within a specific visible/hidden list combination
and not globally across editors.

State changes are now propagated via the `onLayoutChange` callback and
not by reaching into the state of the component.
@maiwald
Simplify calculating visible and hidden lists from layout in Elements…
08c4a70 
…List
@JoachimTillessen @maiwald
provisory button for collapse function
499ab90
@maiwald
Convert Elements to a function component
c80572a
@maiwald
Add element list collapse button functionality
af02936
@maiwald
Fix elements container size
67e23b5 
The Panel components would not be sized properly before. Now they
receive `width: 0` so flex can calculate the size and scrolling is
handled by a separate wrapper.
@maiwald
Add recommended id and order props to resizable panels
6b3d57c 
Also fix warning about invalid layout when detail view is not showing.
@github-actions GitHub Actions
Copy link

LCOV of commit 6b3d57c during Continuous Integration #4150

Summary coverage rate:
  lines......: 65.5% (14030 of 21423 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maiwald @JoachimTillessen