Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New navigation structure #2211

Draft
wants to merge 61 commits into
base: main
Choose a base branch
from
Draft

New navigation structure #2211

wants to merge 61 commits into from

Commits on Nov 15, 2024

  1. Narrow and define ElementAllCheckbox props API

    Instead of passing a complex `ui` prop with undefined keys, we now pass
    only what is necessary to the component.
    
    This shows that the formerly used prop `checked` was not provided.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    cc6fddc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4297c40 View commit details
    Browse the repository at this point in the history
  3. Fix Inbox size dropdown with size small

    The `.small-panel` class adds `overflow: hidden`, hiding the dropdown.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    4846c32 View commit details
    Browse the repository at this point in the history
  4. Disable rather than hide prev/next buttons in element pagination

    This way the buttons jump around less.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    bd69f7f View commit details
    Browse the repository at this point in the history
  5. Separate Home and mydb Navigation components

    With the new layout, the two components will look and function
    differently.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    92afa97 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    f2fe9b4 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    d35cb62 View commit details
    Browse the repository at this point in the history
  8. Fix selecting items from sample import

    While selecting/deselecting would work in production, there were plenty
    of errors in the console because the SelectCellRenderer's rowIndex was
    not used/passed correctly. Probably because of a API change in
    AgGridReact.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    a3f1c55 View commit details
    Browse the repository at this point in the history
  9. Use ElementStore for managing sdf upload confirmation preview

    ...instead of the global NavigationModal
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    f88afaf View commit details
    Browse the repository at this point in the history
  10. Remove NavigationModal and corresponding UI state

    The previous commits make this component obsolete.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    56990e3 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a55c1ac View commit details
    Browse the repository at this point in the history
  12. Remove use of user.profile.data.customClass

    There does not seem to be a way to modify this value and there is no
    personally customizable theming in the new design.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    eeacad1 View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    b35acbb View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    2a7b288 View commit details
    Browse the repository at this point in the history
  15. Restructure App layout

    This patch introduces the app layout structure proposed by Shapefield'
    redesign document.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d5a17dc View commit details
    Browse the repository at this point in the history
  16. Fix reaction SVG size

    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    7c1e0fb View commit details
    Browse the repository at this point in the history
  17. Configuration menu
    Copy the full SHA
    5621e33 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    f410e85 View commit details
    Browse the repository at this point in the history
  19. Add basic Sidebar toggling

    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    1cbec14 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    40f2c5b View commit details
    Browse the repository at this point in the history
  21. Configuration menu
    Copy the full SHA
    1935e96 View commit details
    Browse the repository at this point in the history
  22. Add Support dropdown

    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6183491 View commit details
    Browse the repository at this point in the history
  23. Configuration menu
    Copy the full SHA
    1b61d8d View commit details
    Browse the repository at this point in the history
  24. Configuration menu
    Copy the full SHA
    8905eb2 View commit details
    Browse the repository at this point in the history
  25. Configuration menu
    Copy the full SHA
    b46deb0 View commit details
    Browse the repository at this point in the history
  26. Configuration menu
    Copy the full SHA
    92a536b View commit details
    Browse the repository at this point in the history
  27. Split ScanCodeButton and PrintCodeButton

    ...because scanning is a global action and printing depends on the
    currently selected samples.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    672feb2 View commit details
    Browse the repository at this point in the history
  28. Update CollectionTree to new layout

    We now keep all collection group headers visible on screen by having the
    list of collections in a group scroll when it exceeds the limit of what
    can be displayed.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    ccde10b View commit details
    Browse the repository at this point in the history
  29. Configuration menu
    Copy the full SHA
    114666e View commit details
    Browse the repository at this point in the history
  30. Configuration menu
    Copy the full SHA
    fa09285 View commit details
    Browse the repository at this point in the history
  31. Reduce the number of re-renders of Elements

    We don't use the currentElement prop in ElementDetails. This means that
    we don't need to store it in this component. Subsequently we can boil
    down the state to a single `showDetailView` boolean, making it easy to
    not re-render when nothing has changed.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    3637bf5 View commit details
    Browse the repository at this point in the history
  32. Configuration menu
    Copy the full SHA
    1167796 View commit details
    Browse the repository at this point in the history
  33. Configuration menu
    Copy the full SHA
    9898553 View commit details
    Browse the repository at this point in the history
  34. improve styling for sidebar

    JoachimTillessen authored and maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8edc8af View commit details
    Browse the repository at this point in the history
  35. Configuration menu
    Copy the full SHA
    94d6379 View commit details
    Browse the repository at this point in the history
  36. Configuration menu
    Copy the full SHA
    b5c74e0 View commit details
    Browse the repository at this point in the history
  37. Configuration menu
    Copy the full SHA
    c4b8b05 View commit details
    Browse the repository at this point in the history
  38. Fix spacing in collection tree

    JoachimTillessen authored and maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    962737a View commit details
    Browse the repository at this point in the history
  39. Configuration menu
    Copy the full SHA
    03e7c1e View commit details
    Browse the repository at this point in the history
  40. Configuration menu
    Copy the full SHA
    ce8092a View commit details
    Browse the repository at this point in the history
  41. Add styleguide stub

    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    208ca9f View commit details
    Browse the repository at this point in the history
  42. Configuration menu
    Copy the full SHA
    6b1fe9f View commit details
    Browse the repository at this point in the history
  43. fix naming font files

    JoachimTillessen authored and maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    8d7d65a View commit details
    Browse the repository at this point in the history
  44. implement sheets and sheet-tabs

    JoachimTillessen authored and maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    d708420 View commit details
    Browse the repository at this point in the history
  45. Configuration menu
    Copy the full SHA
    efc9d1e View commit details
    Browse the repository at this point in the history
  46. Remove full screen mode

    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    69f243c View commit details
    Browse the repository at this point in the history
  47. Configuration menu
    Copy the full SHA
    ed6c2dd View commit details
    Browse the repository at this point in the history
  48. Configuration menu
    Copy the full SHA
    c4aaeba View commit details
    Browse the repository at this point in the history
  49. Style resize handle

    JoachimTillessen authored and maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    20ade97 View commit details
    Browse the repository at this point in the history
  50. Configuration menu
    Copy the full SHA
    61237fa View commit details
    Browse the repository at this point in the history
  51. Configuration menu
    Copy the full SHA
    2bc9d9c View commit details
    Browse the repository at this point in the history
  52. Configuration menu
    Copy the full SHA
    7211fd1 View commit details
    Browse the repository at this point in the history
  53. Configuration menu
    Copy the full SHA
    c9ca688 View commit details
    Browse the repository at this point in the history
  54. Fix additional popover Header breaking rounded border

    The first <Popover.Header> is not the first DOM node in the <Popover>.
    React bootstrap prepends another element for the arrow, so :first-child
    does not work here.
    
    I attempted to use `.popover > *:nth-child(n + 2 of .popover-header)`
    but I suppose our css preprocessor does not support the relatively new
    nth-of selector, because the selector is mangled in the compiled output.
    
    https://developer.mozilla.org/en-US/docs/Web/CSS/:nth-child#the_of_selector_syntax
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    5615463 View commit details
    Browse the repository at this point in the history
  55. Rework tab layout editing to proper drag and drop

    This patch introduces the TabLayoutEditor component with a
    drag-and-drop interface for reordering and hiding/showing tabs.
    
    The component accepts an ItemComponent via the `getItemComponent` prop
    for rendering individual items.
    
    With this patch we no longer need to manage the synthetic 'hidden' Tab
    when no tabs are currently hidden. This is now the editor component's
    responsibility and using code does not have to manage that.
    
    This also removes the `DragDropItemTypes.LAYOUT` constant in favor of a
    unique scope for each instance of the editor, because drag-and-drop is
    only supposed to work within a specific visible/hidden list combination
    and not globally across editors.
    
    State changes are now propagated via the `onLayoutChange` callback and
    not by reaching into the state of the component.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    14923ba View commit details
    Browse the repository at this point in the history
  56. Configuration menu
    Copy the full SHA
    08c4a70 View commit details
    Browse the repository at this point in the history
  57. Configuration menu
    Copy the full SHA
    499ab90 View commit details
    Browse the repository at this point in the history
  58. Configuration menu
    Copy the full SHA
    c80572a View commit details
    Browse the repository at this point in the history
  59. Configuration menu
    Copy the full SHA
    af02936 View commit details
    Browse the repository at this point in the history
  60. Fix elements container size

    The Panel components would not be sized properly before. Now they
    receive `width: 0` so flex can calculate the size and scrolling is
    handled by a separate wrapper.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    67e23b5 View commit details
    Browse the repository at this point in the history
  61. Add recommended id and order props to resizable panels

    Also fix warning about invalid layout when detail view is not showing.
    maiwald committed Nov 15, 2024
    Configuration menu
    Copy the full SHA
    6b3d57c View commit details
    Browse the repository at this point in the history