Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paramgen #19

Merged
merged 3 commits into from
Feb 16, 2024
Merged

Paramgen #19

merged 3 commits into from
Feb 16, 2024

Conversation

lovromazgon
Copy link
Member

@lovromazgon lovromazgon commented Feb 14, 2024

Description

This PR moves paramgen from the connector SDK to commons. We want to reuse the tool in connectors and processors, now we can.

Depends on #18.

Quick checks:

  • I have followed the Code Guidelines.
  • There is no other pull request for the same update/change.
  • I have written unit tests.
  • I have made sure that the PR is of reasonable size and can be easily reviewed.

@lovromazgon lovromazgon force-pushed the lovro/paramgen branch 2 times, most recently from 1c60785 to 13f4b2a Compare February 15, 2024 13:57
@lovromazgon lovromazgon marked this pull request as ready for review February 15, 2024 17:00
@lovromazgon lovromazgon requested a review from a team as a code owner February 15, 2024 17:00
@lovromazgon lovromazgon force-pushed the lovro/paramgen branch 3 times, most recently from c04145e to 3cb87a5 Compare February 15, 2024 17:20
Copy link

@maha-hajja maha-hajja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Base automatically changed from lovro/config to main February 16, 2024 17:39
@lovromazgon
Copy link
Member Author

No more force pushing, I promise 🙃 it's a pain to keep the history clean in a stacked PR..

@lovromazgon lovromazgon merged commit d9ab99e into main Feb 16, 2024
5 checks passed
@lovromazgon lovromazgon deleted the lovro/paramgen branch February 16, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants