[WIP] Breaking change - conduit commons parameter #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovromazgon
commented
Feb 15, 2024
Comment on lines
+7
to
+8
| github.com/conduitio/conduit-commons v0.0.0-20240215135739-13f4b2a52642 | ||
| github.com/conduitio/conduit-connector-protocol v0.5.1-0.20240214155157-3daddc9cccf2 |
There was a problem hiding this comment.
Update dependencies with tagged versions before merging.
4 tasks
hariso
reviewed
Feb 15, 2024
Comment on lines
+117
to
+120
| err1 := config.Config(req.Config). | ||
| Sanitize(). | ||
| ApplyDefaults(parameters). | ||
| Validate(parameters) |
hariso
approved these changes
Feb 15, 2024
lovromazgon
changed the title
|
Closing in favor of #130. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Breaking Change - updating connectors to this change requires slightly changing the code. The protocol still stays the same, so all standalone connectors still work the same with Conduit.
This PR removes config parameters and validations in favor of using the config parameters in conduit-commons (see ConduitIO/conduit-commons#18 and ConduitIO/conduit-commons#19). This allows us to reuse the same code in connectors and processors. Also paramgen is now moved to conduit-commons and works for both connectors and processors.
We probably want to merge this together with the move to the
opencdc.Recordtype, as that will also be a breaking change. That's why we do not want to merge this yet, it's prepared for a later point.Quick checks:
update/change.