Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Shovel Silo Loader Mode #2614

Merged
merged 100 commits into from
Sep 20, 2023
Merged

Shovel Silo Loader Mode #2614

merged 100 commits into from
Sep 20, 2023

Conversation

schwiti6190
Copy link
Contributor

@schwiti6190 schwiti6190 commented Jul 12, 2023 •
edited
Loading

Functions:

  • Loading and Unloading with a wheel loader or similar vehicles.
  • Loading from a bunker silo and from heaps on fields.
  • Unloading to trailers and unload triggers.
  • Automatic shovel position control( Loading, Transport, Pre Unload, Unload ).
  • Trailer unload searches for trailer nearby and unloads to them, similar to combine self unload.
  • Unload triggers can be selected on the AI menu map.
  • Added 4x Map AI Map zoom
  • Quality of life improvements for vehicle config

@schwiti6190 schwiti6190 changed the title Shovel position Shovel Silo Loader Mode Jul 12, 2023
@schwiti6190 schwiti6190 force-pushed the ShovelPosition branch 2 times, most recently from e72afeb to 302a940 Compare July 19, 2023 16:25
@schwiti6190 schwiti6190 force-pushed the ShovelPosition branch 2 times, most recently from b98e38f to 50268aa Compare July 21, 2023 09:39
@schwiti6190 schwiti6190 marked this pull request as ready for review September 8, 2023 19:57
@schwiti6190 schwiti6190 requested a review from pvaiko September 8, 2023 19:57
pvaiko
pvaiko reviewed Sep 9, 2023
View reviewed changes
config/VehicleConfigurations.xml Outdated Show resolved Hide resolved
config/VehicleConfigurations.xml
- loadingShovelOffset: number -1 : 1
Offset relative to the calculated loading shovel position, needs to be set for a shovel implement.

- shovelMovingToolIx: number
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here, is this an index? where is it coming from? just a bit more info, please

config/VehicleConfigurations.xml Show resolved Hide resolved
scripts/ai/ImplementUtil.lua Outdated Show resolved Hide resolved
scripts/ai/Markers.lua Show resolved Hide resolved
scripts/specializations/CpAIWorker.lua Show resolved Hide resolved
scripts/specializations/CpAIWorker.lua Outdated
--- if the node is pointing backwards and not forwards.
function CpAIWorker:getAIReverserNode(superFunc)
local spec = self.spec_cpAIWorker
-- if not self:getIsCpActive() then return superFunc(self) end
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed or not?

scripts/specializations/CpAIWorker.lua Outdated Show resolved Hide resolved
scripts/ai/AIDriveStrategyShovelSiloLoader.lua Outdated Show resolved Hide resolved
scripts/ai/AIDriveStrategyShovelSiloLoader.lua Show resolved Hide resolved
@schwiti6190 schwiti6190 force-pushed the ShovelPosition branch 2 times, most recently from 3ecbcc6 to a66905b Compare September 16, 2023 15:37
schwiti6190 and others added 27 commits September 19, 2023 20:22
@schwiti6190
Fixed vehicle config typo
5f52acd
@schwiti6190
Added missing heap filllevel percentage
98681f7
@Tensuko @schwiti6190
EN Translation WIP
cf91cda
@Tensuko @schwiti6190
Updated translations
936b24a
@Tensuko @schwiti6190
Some Translation adjustments
66e4f82
@Tensuko @schwiti6190
Updated translations
2b7e923
@schwiti6190
Changed silo loader status to liter and shovel grabber adjustment
eed8393
@Tensuko @schwiti6190
Translation adjustment and recheck time reduced
fc7dab8 
Info for Translator: Line 96 "Progress" -> "Liters left"
@Tensuko @schwiti6190
Updated translations
dccce59
@schwiti6190
Updated comments
f4e1971
@schwiti6190
Timing callstack fix
98fc18c
@schwiti6190
minior debug adjustment
6a46f82
@schwiti6190
PR Adjustments
cbb38b4
@schwiti6190
Small adjustment for vehicle config
5bd671d
@schwiti6190
debug fix
1dc8ef4
@schwiti6190
Fixes shovel controller mp for now
2ea4cfd
@schwiti6190
Bug fix ...
33c1d96
@schwiti6190
Added additional mp safety check for shovel positions
ec2e6b5
@schwiti6190
Update modDesc.xml
330314a
@schwiti6190
Rebase fix
4ac14e7
@schwiti6190
Added vehicle config for premos
e854464
@schwiti6190
Translation adjustments
43c026e
@schwiti6190
Updated translations
3e78a2d
@schwiti6190
Fixes hud bug
c24c1b6
@schwiti6190
Rebase fix
867576f
@schwiti6190
Removed leftover debug
d9b4082
@schwiti6190
Stops the driver if no path to the silo is found.
1e682d8
@Tensuko Tensuko merged commit c3f4794 into main Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pvaiko pvaiko pvaiko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@schwiti6190 @pvaiko @Tensuko