Pocket #3584
Pocket #3584
Conversation
Instead of the dz, as it depends on the vehicle's heading.
No matter how much try arround with that, the most elegant solution would be having the distance between our reference waypoint and the pipe of the harvester/combine, be long enought to fit the unloader (in meter, as we don't know what unloader will unload the combine). With that known distance, we coould calculate how far we need to drive back, to then drive into the pocket and get our harvester straight.
Forgotten modDesc.xml
Fixed the math.
Use the front marker to create the helper node
scripts/util/HelperNode.lua
Outdated
| ---@param ly number y coordinate of the point relative to the node | ||
| ---@param lz number z coordinate of the point relative to the node | ||
| ---@return number, number, number | ||
| function HelperTerrainNode:localToLocal(node, lx, ly, lz) |
There was a problem hiding this comment.
This function is only working for HelperTerrainNode and not for the base HelperNode
scripts/util/HelperNode.lua
Outdated
| function HelperNode:init(name, rootNode) | ||
| self.node = createTransformGroup(name) | ||
| self.rootNode = rootNode | ||
| link(self.rootNode, self.node) |
There was a problem hiding this comment.
What happens here if rootNode is nil?
| -- A helper node that is linked to the terrain root node, and the y coordinate is always | ||
| -- the terrain height at the x, z position. | ||
| ---@class HelperTerrainNode : HelperNode | ||
| HelperTerrainNode = CpObject(HelperNode) |
There was a problem hiding this comment.
Not sure if inheritence is the best approach here.
I would prefer something like this:
-- Creates a new helper node linked to the terrain root node.
function HelperNode.createTerrainNode(name )
return HelperNode(name, g_currentMission.terrainRootNode)
endThere was a problem hiding this comment.
I had something similar first, the reason I don't like it, is that the behavior/interpretation for the y coordinate is different.
| ---@param y number if the node is linked to the terrain, this is relative to the terrain height at x, z | ||
| ---@param z number | ||
| ---@param yRotation number|nil Rotation set only if not nil | ||
| function HelperTerrainNode:place(x, y, z, yRotation) |
There was a problem hiding this comment.
I would prefer this functionality in a separate function like so maybe:
---@param yRotation number|nil
---@param yOffset number|nil
function HelperNode:placeTerrain(x, z, yRotation, yOffset)
endThere was a problem hiding this comment.
Was struggling with this as well, probably we don't even need a generic HelperNode (at least as of now, I'm not aware of a use case), and should only implement a HelperTerrainNode.
| -- It wraps the creation of the Giant's engine node. | ||
| -- NOTE: it must be destroyed explicitly to avoid node leak. | ||
|
|
||
| ---@class HelperNode |
There was a problem hiding this comment.
This is a fantastic idea :)
Maybe you got the motivation to add missing commanly used functions, like worldToLocal(), localDirectionToWorld().
No description provided.