fix: find bales in missions #144
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bales in missions now have owner 0 (AccessHandler.EVERYONE), so check for that as well.
Closed
schwiti6190
reviewed
Dec 27, 2024
| if not object.mountObject and object:getOwnerFarmId() == self.vehicle:getOwnerFarmId() and | ||
| self:isBaleOnField(bale) then | ||
| if not object.mountObject and | ||
| (object:getOwnerFarmId() == AccessHandler.EVERYONE or |
There was a problem hiding this comment.
Maybe we could use the following function to check the access?
Should also check the AccessHandler.EVERYONE permission. g_currentMission.accessHandler:canFarmAccess(self.vehicle:getOwnerFarmId(), object)
added 2 commits
December 27, 2024 11:48
There really is no reason to avoid the target bale, we want to hit it with the baler/wrapper anyway.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bales in missions now have owner 0 (AccessHandler.EVERYONE), so check for that as well.