chore(cleanup): remove deprecated preferences code #11
Conversation
| @@ -12,451 +12,233 @@ import type { PreferencesData } from 'ember-headless-table'; | |||
| module('Unit | -private | table-preferences', function (hooks) { | |||
| setupTest(hooks); | |||
|
|
|||
| module('deprecated APIs', function () { | |||
There was a problem hiding this comment.
all of these tests have been deleted
There was a problem hiding this comment.
It looks like they have been replaced. Is this prep for the upcoming tests?
There was a problem hiding this comment.
the replacement tests already exist 🎉
| }); | ||
|
|
||
| module('#restore and #persist are inverses', function () { | ||
| // test('mixed top-level keys along with plugin data', async function (assert) { |
There was a problem hiding this comment.
these tests were commented out because of sinon usage, and sinon does not natively support running in browsers (it tries to import util, which is a known node package -- there is a browser version of util, but I opted to have fewer dependencies).
The tests using non-deprecated APIs have been re-enabled and have had their sinon usage removed
NullVoxPopuli
requested review from
vitch,
ynotdraw,
camskene and
nicolechung
Preview URLsGH Env: preview |
NullVoxPopuli
force-pushed
the
remove-deprecated-preferences-code
branch
from
3a23c56 to
87c7079
Compare
|
Unrelated, but I raised this issue because I can't seem to run |
|
🎉 This PR is included in version 1.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Now that everything is plugins, we don't need this anymore