Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update FIG chart to the latest released version 3.2.0 #297

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

redhatrises
Copy link
Contributor

No description provided.

Copy link
Contributor

@carlosmmatos carlosmmatos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outside of the requestd change, I think it looks good

@carlosmmatos carlosmmatos added the enhancement New feature or request label Jun 14, 2024
@redhatrises redhatrises linked an issue Jun 17, 2024 that may be closed by this pull request
@redhatrises redhatrises merged commit 3a21721 into CrowdStrike:main Jun 17, 2024
2 checks passed
@redhatrises redhatrises deleted the fig_update branch June 17, 2024 16:17
@mkeats-clumio
Copy link

mkeats-clumio commented Jun 18, 2024

@redhatrises there wasn't a 0.4.0 version published in the helm repo for this change. The latest is still 0.3.0
The github action failed due to falcon-kac-1.1.2 already existing https://github.com/CrowdStrike/falcon-helm/actions/runs/9551134785

@mkeats-clumio
Copy link

@redhatrises looks like it published after I posted that.

Testing the new version I found a problem with the way you templated out the config

    #confirm_instance = true
    {{- if .Values.push.aws_security_hub.confirm_instance }}
    confirm_instance = {{ .Values.push.aws_security_hub.confirm_instance }}
    {{- end }}

{{- if .Values.push.aws_security_hub.confirm_instance }} is only evaluated true if confirm_instance is set to true. So it makes it impossible to ever override the default true value which I found out when trying to set it to false. We want to check if the value is defined, not if it is true.

It would be simpler just to remove the conditional and let confirm_instance pick up default value of true if not overridden. This would apply for the other vars too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integration Gateway does not take existing secret
3 participants