-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update FIG chart to the latest released version 3.2.0 #297
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Outside of the requestd change, I think it looks good
@redhatrises there wasn't a 0.4.0 version published in the helm repo for this change. The latest is still 0.3.0 |
@redhatrises looks like it published after I posted that. Testing the new version I found a problem with the way you templated out the config
It would be simpler just to remove the conditional and let confirm_instance pick up default value of true if not overridden. This would apply for the other vars too. |
No description provided.