Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Trigger recruited with pending conditions email #8679

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

stevehook
Copy link
Collaborator

@stevehook stevehook commented Oct 13, 2023

Context

It would be beneficial to SCITT providers if we allowed them to move a candidate who was only pending SKE conditions to ‘Recruited’ as this would automatically import their record into Register saving them from having to manually create it. This is particularly useful for providers (and DfE) who are busy getting their ITT data ready for the ITT census deadline in October.

Implementing this will move a candidate to ‘Recruited’ status, meaning that they will be included in the next import from Apply to Register (a job that currently runs at 4am every day).

This PR is needed to ensure that candidates that are recruited with a pending SKE condition are notified (by email) that they need to complete that SKE course.

Changes proposed in this pull request

This PR adapts the existing CandidateMailer#met_conditions email template to include a reminder for candidates to complete their SKE course as a condition to their upcoming teacher training course.

Without pending SKE conditions

image

With pending SKE conditions

image

Guidance to review

Anything missing?

Link to Trello card

https://trello.com/c/XEmUYTe2/6162-trigger-recruited-with-pending-conditions-email

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Required environment variables have been updated added to the Azure KeyVault

@stevehook stevehook added Candidate Candidate facing issue Ruby Pull requests that update Ruby code deploy_v2 Deploy the review app to AKS labels Oct 13, 2023
@stevehook stevehook changed the base branch from main to 6161-recruit-with-pending-conditions-button-on-manage-status-tags October 13, 2023 11:13
@github-actions
Copy link
Contributor

Database-level enum changes detected

Please include a data migration for these attributes and values:

4c4
<   �[1m�[36mActiveRecord::SchemaMigration Pluck (1.9ms)�[0m  �[1m�[34mSELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC�[0m
---
>   �[1m�[36mActiveRecord::SchemaMigration Pluck (1.8ms)�[0m  �[1m�[34mSELECT "schema_migrations"."version" FROM "schema_migrations" ORDER BY "schema_migrations"."version" ASC�[0m
5a6,8
>   �[1m�[36mTRANSACTION (0.2ms)�[0m  �[1m�[35mBEGIN�[0m
>   �[1m�[36mAudited::Audit Create (2.1ms)�[0m  �[1m�[32mINSERT INTO "audits" ("auditable_id", "auditable_type", "associated_id", "associated_type", "user_id", "user_type", "username", "action", "audited_changes", "version", "comment", "remote_address", "request_uuid", "created_at") VALUES ($1, $2, $3, $4, $5, $6, $7, $8, $9, $10, $11, $12, $13, $14) RETURNING "id"�[0m  [["auditable_id", 1], ["auditable_type", "SiteSetting"], ["associated_id", nil], ["associated_type", nil], ["user_id", nil], ["user_type", nil], ["username", nil], ["action", "create"], ["audited_changes", "{\"name\":\"cycle_schedule\",\"value\":null}"], ["version", 1], ["comment", nil], ["remote_address", nil], ["request_uuid", "89d90ba1-de66-4b84-a9b4-665164e288e4"], ["created_at", "2023-10-13 11:14:18.428794"]]
>   �[1m�[36mTRANSACTION (0.6ms)�[0m  �[1m�[35mCOMMIT�[0m
8a12
> <enum> Provider.provider_type: ["lead_school", "scitt", "university"]

@stevehook stevehook added deploy_v2 Deploy the review app to AKS and removed deploy_v2 Deploy the review app to AKS labels Oct 13, 2023
@github-actions github-actions bot temporarily deployed to review_aks-8679 October 13, 2023 11:42 Destroyed
@stevehook stevehook temporarily deployed to review_aks October 13, 2023 11:42 — with GitHub Actions Inactive
@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch from f54e528 to c42076e Compare October 13, 2023 14:20
@stevehook stevehook force-pushed the 6162-trigger-recruited-with-pending-conditions-email branch from eef36f4 to 5931e94 Compare October 16, 2023 07:19
@stevehook stevehook force-pushed the 6161-recruit-with-pending-conditions-button-on-manage-status-tags branch 4 times, most recently from 55ec3dd to 651217c Compare October 17, 2023 09:45
Base automatically changed from 6161-recruit-with-pending-conditions-button-on-manage-status-tags to main October 17, 2023 10:59
@stevehook stevehook force-pushed the 6162-trigger-recruited-with-pending-conditions-email branch from 5931e94 to 55349ca Compare October 17, 2023 12:19
@github-actions github-actions bot temporarily deployed to review_aks-8679 October 17, 2023 12:24 Destroyed
@stevehook stevehook temporarily deployed to review_aks October 17, 2023 12:24 — with GitHub Actions Inactive
@stevehook stevehook force-pushed the 6162-trigger-recruited-with-pending-conditions-email branch from 55349ca to f9af2a7 Compare October 17, 2023 12:33
@github-actions github-actions bot temporarily deployed to review_aks-8679 October 17, 2023 12:42 Destroyed
@stevehook stevehook temporarily deployed to review_aks October 17, 2023 12:42 — with GitHub Actions Inactive
@stevehook stevehook force-pushed the 6162-trigger-recruited-with-pending-conditions-email branch from f9af2a7 to d630c71 Compare October 17, 2023 13:32
@github-actions github-actions bot temporarily deployed to review_aks-8679 October 17, 2023 13:36 Destroyed
@stevehook stevehook temporarily deployed to review_aks October 17, 2023 13:37 — with GitHub Actions Inactive
@stevehook stevehook force-pushed the 6162-trigger-recruited-with-pending-conditions-email branch from d630c71 to b6460a2 Compare October 17, 2023 15:10
@github-actions github-actions bot temporarily deployed to review_aks-8679 October 17, 2023 15:14 Destroyed
@stevehook stevehook temporarily deployed to review_aks October 17, 2023 15:14 — with GitHub Actions Inactive
@stevehook stevehook merged commit f319030 into main Oct 17, 2023
59 checks passed
@stevehook stevehook deleted the 6162-trigger-recruited-with-pending-conditions-email branch October 17, 2023 16:15
@stevehook stevehook temporarily deployed to review_aks October 17, 2023 16:15 — with GitHub Actions Inactive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Candidate Candidate facing issue deploy_v2 Deploy the review app to AKS Ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants