-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trigger recruited with pending conditions email #8679
Merged
stevehook
merged 4 commits into
main
from
6162-trigger-recruited-with-pending-conditions-email
Oct 17, 2023
Merged
Trigger recruited with pending conditions email #8679
stevehook
merged 4 commits into
main
from
6162-trigger-recruited-with-pending-conditions-email
Oct 17, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevehook
added
Candidate
Candidate facing issue
Ruby
Pull requests that update Ruby code
deploy_v2
Deploy the review app to AKS
labels
Oct 13, 2023
stevehook
changed the base branch from
main
to
6161-recruit-with-pending-conditions-button-on-manage-status-tags
October 13, 2023 11:13
Database-level enum changes detected Please include a data migration for these attributes and values:
|
stevehook
added
deploy_v2
Deploy the review app to AKS
and removed
deploy_v2
Deploy the review app to AKS
labels
Oct 13, 2023
stevehook
force-pushed
the
6161-recruit-with-pending-conditions-button-on-manage-status-tags
branch
from
October 13, 2023 14:20
f54e528
to
c42076e
Compare
stevehook
force-pushed
the
6162-trigger-recruited-with-pending-conditions-email
branch
from
October 16, 2023 07:19
eef36f4
to
5931e94
Compare
MaeveRoseveare
approved these changes
Oct 16, 2023
JR-G
approved these changes
Oct 16, 2023
stevehook
force-pushed
the
6161-recruit-with-pending-conditions-button-on-manage-status-tags
branch
4 times, most recently
from
October 17, 2023 09:45
55ec3dd
to
651217c
Compare
Base automatically changed from
6161-recruit-with-pending-conditions-button-on-manage-status-tags
to
main
October 17, 2023 10:59
If there are pending SKE conditions then we need to remind the candidate about that.
stevehook
force-pushed
the
6162-trigger-recruited-with-pending-conditions-email
branch
from
October 17, 2023 12:19
5931e94
to
55349ca
Compare
stevehook
force-pushed
the
6162-trigger-recruited-with-pending-conditions-email
branch
from
October 17, 2023 12:33
55349ca
to
f9af2a7
Compare
stevehook
force-pushed
the
6162-trigger-recruited-with-pending-conditions-email
branch
from
October 17, 2023 13:32
f9af2a7
to
d630c71
Compare
stevehook
force-pushed
the
6162-trigger-recruited-with-pending-conditions-email
branch
from
October 17, 2023 15:10
d630c71
to
b6460a2
Compare
stevehook
deleted the
6162-trigger-recruited-with-pending-conditions-email
branch
October 17, 2023 16:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
It would be beneficial to SCITT providers if we allowed them to move a candidate who was only pending SKE conditions to ‘Recruited’ as this would automatically import their record into Register saving them from having to manually create it. This is particularly useful for providers (and DfE) who are busy getting their ITT data ready for the ITT census deadline in October.
Implementing this will move a candidate to ‘Recruited’ status, meaning that they will be included in the next import from Apply to Register (a job that currently runs at 4am every day).
This PR is needed to ensure that candidates that are recruited with a pending SKE condition are notified (by email) that they need to complete that SKE course.
Changes proposed in this pull request
This PR adapts the existing
CandidateMailer#met_conditions
email template to include a reminder for candidates to complete their SKE course as a condition to their upcoming teacher training course.Without pending SKE conditions
With pending SKE conditions
Guidance to review
Anything missing?
Link to Trello card
https://trello.com/c/XEmUYTe2/6162-trigger-recruited-with-pending-conditions-email
Things to check