Highlight candidate application edits on manage #8695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inulty-dfe
changed the title
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage
branch
from
d9aceff to
a7395f9
Compare
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage
branch
from
751e665 to
9a8aea9
Compare
Instance method on an ApplicationChoice which determines if the ApplicationChoice has been updated within a specific duration since it was submitted to the provider. The default duration is 40 days.
If the ApplicationChoice has been updated recently, show an notification banner with a link to the application timeline.
Add - Personal details - Contact information - Disability disclosure - Interview preferences - Equality and diversity
Include index page assertions
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage
branch
from
b04e2e2 to
b1ace76
Compare
lsalivonaite-transform
approved these changes
Oct 18, 2023
tomas-stefano
approved these changes
Oct 18, 2023
zarembas
reviewed
Oct 18, 2023
app/models/application_choice.rb
Outdated
| return false if sent_to_provider_at.blank? | ||
|
|
||
| since = [UPDATED_RECENTLY_DAYS.days.ago, sent_to_provider_at].max | ||
| RecentlyUpdatedApplicationChoice.new.call(application_choice: self, since: since).exists? |
There was a problem hiding this comment.
Can't since be moved inside RecentlyUpdatedApplicationChoice? And you can have RecentlyUpdatedApplicationChoice.new.call(application_choice: self).exists?
And then the method wouldn't even need to be part of the instance.
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage
branch
from
f07f95e to
77c8cba
Compare
zarembas
approved these changes
Oct 18, 2023
JR-G
approved these changes
Oct 18, 2023
inulty-dfe
force-pushed
the
33-ca-highlight-candidate-application-edits-on-manage
branch
from
77c8cba to
d1d1dea
Compare
inulty-dfe
deleted the
33-ca-highlight-candidate-application-edits-on-manage
branch
This was referenced Oct 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Providers will want to be aware when a candidate has updated their submitted application.
The ticket outlined an implementation where the data that was changed is shown in the Timeline. I have not implemented this in this PR as it would require consideration about how and what could be shared between the history component and the timeline component.
As a stopgap, the link to "View Application" in the Timeline brings the user to the specific section of the application that has been changed.
Screenshots
Changes proposed in this pull request
Guidance to review
Link to Trello card
Trello Ticket