Introducing support functionality to grant an editable extension to any non editable section

[tomas-stefano]

Context

A support user will be able to click a button to ‘make the application editable’. On a new page, they will then be able to set a non editable section temporarily editable and the code will automatically calculate the date until the candidate will be able to edit.
This will set the editable_until value.

We’ll also request the Zendesk link of the originating request. Once set, the support user will return to the candidate’s application view and will be able to see the ‘editable until’ value rendered. when editable_until > current date, the candidate can edit all sections selected via support.

Changes proposed in this pull request

Then the sections are editable for 5 business days

Guidance to review

1. Does it work for all sections (checked and unchecked) via support?

Link to Trello card

https://trello.com/c/CCPhwAUW/870-ca-introduce-5-day-editable-window

[zarembas]

One issue would also be not letting the candidates delete references because it's not possible after submission. Maybe hide the Delete link?

[MaeveRoseveare]

Thanks @tomas-stefano I played around and nothing broke for me.

I noted 1 validation point - I can select 'Update' without selecting any of the check boxes.

And on @vassyz comments, yes agreed - I have provided solutions in this same doc (scroll down)

[inulty-dfe]

In the interest of time I'm happy to approve but I've added some thoughts I think we should consider.

[inulty-dfe]

Crazy suggestion:

subject&.== 'maths'

[inulty-dfe]

I made the suggestion to pass a block here but the way it's been implemented means it is unnecessary.

The point was to avoid defining *_gcse? methods on the Section class because that method only applies to a GCSE section with subject *. If another GCSE was added (unlikely of course) then a new method would need to be added.

I expected the whole condition (the contents of the *_gcse? method) to be passed directly to the block.

      Section.new(
        :english_gcse,
        controller: 'CandidateInterface::Gcse',
        editable_condition: lambda { |policy|
          params = policy.params
          subject = params[:subject]

          (subject && subject == 'english') || policy.controller_path.include?('candidate_interface/gcse/english')
        },
      ),

[inulty-dfe]

Also, how do you feel about editable_if: instead of editable_condition:

[JR-G]

Approved – I've already added a card to feature flag this, and I'll add further cards for us to address all the valid points raised on this piece of functionality!