Update Warning component on accessibility audits page #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Typo fixed, content tweaked so it's easier to read. Signed-off-by: adyhoran1 <[email protected]>
andyjones81
reviewed
May 5, 2024
| @@ -11,8 +11,8 @@ | |||
| <div class="govuk-warning-text"> | |||
| <span class="govuk-warning-text__icon" aria-hidden="true">!</span> | |||
| <strong class="govuk-warning-text__text"> | |||
| <span class="govuk-warning-text__assistive">Warning</span> | |||
| Services built using the prototype kit, must not be presented for audits. They are not intended for production quality products or services. | |||
| <span class="govuk-warning-text__assistive"> Warning </span> | |||
There was a problem hiding this comment.
Can you explain why you've made these changes to the warning component and put the text in quotes.
There was a problem hiding this comment.
@andyjones81 the warning component is currently not displaying correctly on the page:
This was my attempt at fixing it 🙂
adyhoran1
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Typo fixed, content tweaked so it's easier to read.