-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Warning component on accessibility audits page #191
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -11,8 +11,8 @@ | |
<div class="govuk-warning-text"> | ||
<span class="govuk-warning-text__icon" aria-hidden="true">!</span> | ||
<strong class="govuk-warning-text__text"> | ||
<span class="govuk-warning-text__assistive">Warning</span> | ||
Services built using the prototype kit, must not be presented for audits. They are not intended for production quality products or services. | ||
<span class="govuk-warning-text__assistive"> Warning </span> | ||
"Services built using the prototype kit, must not be presented for audits. They are not intended for production quality products or services." | ||
</strong> | ||
</div> | ||
|
||
|
@@ -23,11 +23,11 @@ <h2 class="govuk-heading-m">Testing and templates</h2> | |
<p>You should have your service audited by a professional accessibility auditor, such as an <a class="govuk-link" href="https://www.digitalmarketplace.service.gov.uk/buyers/frameworks/digital-outcomes-and-specialists-5/requirements/digital-outcomes" target="_blank">external audit provider</a> or the <a href="mailto:[email protected]">DfE internal accessibility team</a>.</p> | ||
<p>The audit should satisfy the <a class="govuk-link" target="_blank" href="https://www.gov.uk/service-manual/helping-people-to-use-your-service/getting-an-accessibility-audit">audit requirements in the GOV.UK Service Manual</a> for device and browser combinations.</p> | ||
|
||
<p>Before you send the service for an audiotr to review, you can find common issues by <a href="https://gist.github.com/tvararu/8752e3ec5446bfafa9224db958b48e79" class="govuk-link" target="_blank">using this Trello template</a>.</p> | ||
<p>Before you send the service for an auditor to review, you can find common issues by using this <a href="https://gist.github.com/tvararu/8752e3ec5446bfafa9224db958b48e79" class="govuk-link" target="_blank">Trello template</a>.</p> | ||
|
||
<p>You can also use the <a class="govuk-link" href="/downloads/wcag-checklist-december-2022.xlsx">spreadsheet to test against the full WCAG guidelines</a> as a checklist.</p> | ||
|
||
<h2 class="govuk-heading-m">Prepare a requirements brief for an audit using WCAG-EM</h2> | ||
<h2 class="govuk-heading-m">Prepare a requirements brief</h2> | ||
|
||
<p>Audit requirements and reporting should be completed in line with <a class="govuk-link" href="/accessibility/evaluation-methodology">Website Accessibility Conformance Evaluation Methodology (WCAG-EM)</a>.</p> | ||
|
||
|
@@ -41,4 +41,4 @@ <h2 class="govuk-heading-m">Prepare a requirements brief for an audit using WCAG | |
<li>if any part of your service was built by a third party</li> | ||
</ul> | ||
|
||
{% endblock %} | ||
{% endblock %} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you explain why you've made these changes to the warning component and put the text in quotes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@andyjones81 the warning component is currently not displaying correctly on the page:
This was my attempt at fixing it 🙂