Update webhook env var in SlackClient #1030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steventux
approved these changes
Feb 21, 2024
This env var hasn't been set for the production app since the AKS migration, and is needed by SlackClient for reporting performance alerts and Zendesk health to Slack. Secrets for this service are now split into infra and app lists. The infra list contains a Slack webhook URL that is used when database backups fail. We need that same URL in the app list. In addition to adding SLACK_WEBHOOK to the app secrets via the Azure Portal, this PR simply aligns the name of the env var between the two places in the codebase it is currently used.
malcolmbaig
force-pushed
the
1786-slack-webhook-fix
branch
from
1a7e8af to
f6556f0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This env var hasn't been set for the production app since the AKS migration, and is needed by SlackClient for reporting performance alerts and Zendesk health to Slack.
Changes proposed in this pull request
Secrets for this service are now split into infra and app lists. The infra list contains a Slack webhook URL that is used when database backups fail. We need that same URL in the app list.
In addition to adding SLACK_WEBHOOK to the app secrets via the Azure Portal, this PR simply aligns the name of the env var between the two places in the codebase it is currently used.
Guidance to review
I'll manually test SlackClient on a console once this is merged.
Checklist