Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[2061] Fix tests which will fail when the current cycle ends #4383

Merged
merged 1 commit into from
Jul 18, 2024

Conversation

avinhurry
Copy link
Collaborator

@avinhurry avinhurry commented Jul 17, 2024

Context

Fixing a couple of tests which will fail when the current cycle ends.

Changes proposed in this pull request

Fix the tests dynamically so they work in both cycles.

Guidance to review

Do the tests pass all the time regardless of the cycle?

Checklist

  • Make sure all information from the Trello card is in here
  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Inform data insights team due to database changes

@avinhurry
Copy link
Collaborator Author

@avinhurry avinhurry marked this pull request as ready for review July 17, 2024 17:46
@avinhurry avinhurry merged commit b4ac7e7 into main Jul 18, 2024
19 checks passed
@avinhurry avinhurry deleted the 2061-fix-tests-which-will-fail-when-rollover-ends branch July 18, 2024 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants