Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invite Users to GSE #3080

Merged
merged 28 commits into from
Mar 11, 2024
Merged

Invite Users to GSE #3080

merged 28 commits into from
Mar 11, 2024

Conversation

ekumachidi
Copy link
Contributor

@ekumachidi ekumachidi commented Feb 16, 2024

Trello card

#5535

Context

We want to Integrate the Identity only version of DfE Sign-in with Get School Experience
Build pages to add users to a school.
Allow school administrators to invite users to the school that they administer through 'School Dashboard'

Changes proposed in this pull request

  • Add link to manage users in school dashboard

Guidance to review

@github-actions github-actions bot added the ruby Pull requests that update Ruby code label Feb 16, 2024
Due to ci failures; this is a temporal fix to to enable new build success.
- Update schema version
- Remove `:email`, `:last_name`, `:first_name` from users table
- Refactor user creation and show page
- Remove redundant <div>
Refactor user creation logic in Schools::UsersController
- Fix user attribute names in show.html.erb
- Add change links to user details in show.html.erb
Refactor user_invite.rb
update parameter name
Copy link

@ekumachidi ekumachidi merged commit c280eb6 into ce-dsi-id-only Mar 11, 2024
15 checks passed
@ekumachidi ekumachidi deleted the ce-invite-users branch March 11, 2024 19:16
@tejasjinaraldfe
Copy link

Review app deployed to https://get-school-experience-review-pr-3080.test.teacherservices.cloud ✅ DfE sign in route obtained: https://get-school-experience-review-pr-8.test.teacherservices.cloud

@ekumachidi please find below the comments as discussed during testing

  1. Add user first step - Firstname & Lastname change to First name & Last name

  2. On /schools/users page - DfE Sign-in link should redirect users to /approvals/users on the respective environments

  3. On /schools/users page when a new user is invited -

a. If the user already has a DfE Sign-in account:

  • They can access the school but do not appear in the user list on the page
  • They do not receive any email notification confirming that they have been granted access to manage a new school

b. If the user does not have a DfE Sign-in account:

  • They receive an email notification inviting them to create an account on DfE sign-in but does not say anything which service they have been invited to manage or for which organisation
  • After then sign-in, they can access the school but do not appear in the user list on the page
  1. When the user logs out, they do not get redirected back to the Manage School Experience and see the following error

Error
invalid_request
post_logout_redirect_uri not registered

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Config DevOps Review ruby Pull requests that update Ruby code Test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants