Update user invite flow #3111
Merged
Update user invite flow #3111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
8e516f4 to
f259f47
Compare
- Adds new link to school approvers to school_dashboard - Adds new route and controller for school_approvers - Adds approver#index to display school approvers - Removes school users list from users#index
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
e5d2750 to
97a5d6c
Compare
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
cd0838d to
e942525
Compare
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
e942525 to
4dacd46
Compare
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
4dacd46 to
bbef7c9
Compare
Due to limitations on the DSI public API, we've had to re-evaluate some of bits of this work and at the moment displaying the list of users in the school or their approvers does not seem like much value. This fix addresses it by: - Removes link to school approvers from school dashboard - Removing approver users route, controller and index view - Removing `organisation_users` - Removing specs for `organisation_users`
ekumachidi
force-pushed
the
ce-invite-flow-updates
branch
from
bbef7c9 to
ef58c1b
Compare
|
Review app deployed to https://get-school-experience-review-pr-3111.test.teacherservices.cloud |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/KSbGXeZ5
Context
After preliminary validations, a decision was made to further modify the flow of the user invite process, introducing additional screens and simplifying existing ones.
Changes proposed in this pull request