Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add breadcrumbs to pages without them #3168

Merged
merged 16 commits into from
May 13, 2024
Merged

Add breadcrumbs to pages without them #3168

Show file tree
Hide file tree
Changes from 10 commits
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
3989c06
Add breadcrumbs to turn profile on/off
MylesJarvis Apr 26, 2024
fa8a26c
Update edit.html.erb
MylesJarvis Apr 26, 2024
bf49994
Fix curly bracket missing
MylesJarvis Apr 26, 2024
0610172
Update name for breadcrumbs
MylesJarvis Apr 26, 2024
51ada18
Add backlink
MylesJarvis Apr 26, 2024
7697a55
more backlinks
MylesJarvis Apr 26, 2024
cb60628
Add breadcrumbs to close placement date page
MylesJarvis Apr 29, 2024
05687e0
Update close_confirmation.html.erb
MylesJarvis Apr 29, 2024
2bba259
Feedback page add back button
MylesJarvis Apr 30, 2024
26e2523
Merge branch 'master' into add-breadcrumbs
MylesJarvis May 2, 2024
acaf642
Remove backlink
MylesJarvis May 3, 2024
0a9e723
Remove backlink - contact us
MylesJarvis May 3, 2024
475b65f
Amend toggle requests title
MylesJarvis May 3, 2024
93cddf1
Fix typo
MylesJarvis May 3, 2024
e80ca8c
Remove backlink
MylesJarvis May 3, 2024
993c03a
Fix test
MylesJarvis May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions app/views/feedbacks/_form.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
<% content_for :back_link do govuk_back_link; end %>
MylesJarvis marked this conversation as resolved.
Show resolved Hide resolved

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<%= form_for feedback do |f| %>
Expand Down
9 changes: 8 additions & 1 deletion app/views/schools/availability_preferences/edit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<%- self.page_title = "Choose how dates are displayed" %>
<%- self.page_title = "Choose how dates are displayed"

self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Choose how dates are displayed' => nil
}

%>

<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
Expand Down
2 changes: 1 addition & 1 deletion app/views/schools/confirmed_bookings/cancellations/notification_deliveries/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
What happens next
</h2>
<p>
We’ve sent your response to <%= @cancellation.candidate_name %>
We’ve sent your response to <%= @cancellation.candidate_name %>.
</p>
<p>
We've also sent them a text message asking them to check their inbox.
Expand Down
2 changes: 1 addition & 1 deletion app/views/schools/contact_us/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<% self.page_title = "Contact us" %>

<% content_for :back_link do govuk_back_link(schools_dashboard_path); end %>
MylesJarvis marked this conversation as resolved.
Show resolved Hide resolved
<div class="govuk-grid-row">
<div class="govuk-grid-column-full">
<h1 class="govuk-heading-l">Contact us</h1>
Expand Down
2 changes: 2 additions & 0 deletions app/views/schools/organisation_access_requests/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
<% content_for :back_link do govuk_back_link(schools_dashboard_path); end %>
<div id="dsi-org-access-request" class="govuk-grid-row">
<div class="govuk-grid-column-full">
<section>

<%= page_heading "Request access to another organisation" %>

<% if @dfe_sign_in_request_organisation_url %>
Expand Down
10 changes: 10 additions & 0 deletions app/views/schools/placement_dates/close_confirmation.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,13 @@
<% self.page_title = 'Close placement date' %>

<%
self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Manage dates' => schools_placement_dates_path,
"Close placement on #{@placement_date.date.to_formatted_s(:govuk)}" => nil
}
%>

MylesJarvis marked this conversation as resolved.
Show resolved Hide resolved
<div class="govuk-main-wrapper">
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
Expand Down
2 changes: 1 addition & 1 deletion app/views/schools/placement_requests/cancellations/notification_deliveries/show.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
What happens next
</h2>
<p>
We’ve sent your response to <%= @cancellation.candidate_name %>
We’ve sent your response to <%= @cancellation.candidate_name %>.
</p>

<%= govuk_link_to 'Return to requests', schools_placement_requests_path %>
Expand Down
9 changes: 8 additions & 1 deletion app/views/schools/toggle_enabled/edit.html.erb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,11 @@
<% self.page_title = "Toggle requests" %>
<% self.page_title = "Toggle requests"

MylesJarvis marked this conversation as resolved.
Show resolved Hide resolved
self.breadcrumbs = {
@current_school.name => schools_dashboard_path,
'Turn profile on or off' => nil
}

%>

<%= form_for @current_school, url: schools_enabled_path, method: 'patch' do |f| %>
<%= f.govuk_radio_buttons_fieldset(:enabled) do %>
Expand Down
Loading