Dedicated redis and postgresql for review app #3308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
vipin-dfe
force-pushed
the
dedicated_redis_postgres_review_app
branch
from
6ce294b to
554c716
Compare
|
Closing PR. |
|
Test closing |
saliceti
force-pushed
the
dedicated_redis_postgres_review_app
branch
from
c9bc068 to
d58904a
Compare
saliceti
reviewed
Nov 15, 2024
saliceti
reviewed
Nov 15, 2024
If the database does not exist, db:prepare will create it, load the schema and run db:seed
- Stop using shared postgres and redis - Use container postgres and redis in review - Do not create the database in review, to force running db:prepare with the seed - Refactor to use the standard Rails DATABASE_URL - Remove unused variables - Remove unused keyvaul data sources - Formatting
Use sample schools to align with DfE Sign In Remove redundant tests
saliceti
force-pushed
the
dedicated_redis_postgres_review_app
branch
from
e33dc43 to
2f2672e
Compare
|
Test closing |
|
Review app deployed to https://get-school-experience-review-pr-3308.test.teacherservices.cloud |
saliceti
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
https://trello.com/c/kh03fNsN
Context
The school experience review application uses a shared Redis and Postgresql instance. This change will allow a dedicated Redis and Postgresql pod to be deployed for every PR.
Changes proposed in this pull request
The following changes are proposed as part of the change
Guidance to review
All changes are only to allow for a dedicated Redis and Postgresql for review app.