Compute extension_radial posterior directly and use this for parameter estimates, as opposed to using extension+ellipticity summary statistics #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Part 1 of an improvement to use the full posterior when calculating the azimuthally-averaged (radial) extension. This fix specifically adds extension_radial to the class method supplement(), part of the Samples class
…pute extension_radial estimate Part 2 of an improvement to use the full posterior of the extension and ellipticity to derive extension_radial samples, then compute summary statistics on extension_radial.
|
@chinyitan heads up on these (we'd like to make calculations consistent in future analyses). Happy to add you as a collaborator if you would be willing to review this PR. |
|
It'd be good to address PR #97 as well, although from extensive testing it doesn't seem like it matters too much in the end. |
|
Let's talk about PR #97 on that issue. |
|
I'm going to close and reopen this to see if I can trigger the test workflow to run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Compute extension_radial posterior directly and use this for parameter estimates, as opposed to using extension+ellipticity summary statistics.
Two part solution - first, add storage of extension_radial samples to ugali.utils.stats's Samples class, and then add handling of results in ugali.analysis.results