Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CWS] onboard first batch of fs constants to the fetcher #32700

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

paulcacheux
Copy link
Contributor

What does this PR do?

This PR onboards a first batch of constant to the offset fetcher system, ensuring we reliably read at the correct offset.

Motivation

Describe how you validated your changes

Possible Drawbacks / Trade-offs

Additional Notes

@paulcacheux paulcacheux added changelog/no-changelog team/agent-security qa/done QA done before merge and regressions are covered by tests labels Jan 6, 2025
@github-actions github-actions bot added component/system-probe medium review PR review might take time labels Jan 6, 2025
@paulcacheux paulcacheux marked this pull request as ready for review January 6, 2025 16:05
@paulcacheux paulcacheux requested a review from a team as a code owner January 6, 2025 16:05
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 6, 2025

Uncompressed package size comparison

Comparison with ancestor 4373b4ebe4ab3b683c2ed7f4f666e91d6b78d70a

Diff per package
package diff status size ancestor threshold
datadog-agent-arm64-deb 0.16MB ⚠️ 940.54MB 940.38MB 140.00MB
datadog-agent-aarch64-rpm 0.16MB ⚠️ 949.84MB 949.68MB 140.00MB
datadog-agent-x86_64-rpm 0.16MB ⚠️ 1207.49MB 1207.33MB 140.00MB
datadog-agent-x86_64-suse 0.16MB ⚠️ 1207.49MB 1207.33MB 140.00MB
datadog-agent-amd64-deb 0.16MB ⚠️ 1198.17MB 1198.01MB 140.00MB
datadog-dogstatsd-amd64-deb 0.00MB 79.00MB 79.00MB 10.00MB
datadog-dogstatsd-x86_64-rpm 0.00MB 79.08MB 79.08MB 10.00MB
datadog-dogstatsd-x86_64-suse 0.00MB 79.08MB 79.08MB 10.00MB
datadog-dogstatsd-arm64-deb 0.00MB 56.11MB 56.11MB 10.00MB
datadog-heroku-agent-amd64-deb 0.00MB 506.12MB 506.12MB 70.00MB
datadog-iot-agent-amd64-deb 0.00MB 113.78MB 113.78MB 10.00MB
datadog-iot-agent-x86_64-rpm 0.00MB 113.85MB 113.85MB 10.00MB
datadog-iot-agent-x86_64-suse 0.00MB 113.85MB 113.85MB 10.00MB
datadog-iot-agent-arm64-deb 0.00MB 109.23MB 109.23MB 10.00MB
datadog-iot-agent-aarch64-rpm 0.00MB 109.30MB 109.30MB 10.00MB

Decision

⚠️ Warning

@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Jan 6, 2025

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv aws.create-vm --pipeline-id=52252920 --os-family=ubuntu

Note: This applies to commit fdccada

@paulcacheux
Copy link
Contributor Author

/merge

@dd-devflow
Copy link

dd-devflow bot commented Jan 6, 2025

Devflow running: /merge

View all feedbacks in Devflow UI.


2025-01-06 16:51:51 UTC ℹ️ MergeQueue: waiting for PR to be ready

This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals.
Note: if you pushed new commits since the last approval, you may need additional approval.
You can remove it from the waiting list with /remove command.


2025-01-06 18:34:24 UTC ℹ️ MergeQueue: merge request added to the queue

The median merge time in main is 35m.


2025-01-06 19:10:45 UTC ℹ️ MergeQueue: This merge request was merged

@github-actions github-actions bot added long review PR is complex, plan time to review it and removed medium review PR review might take time labels Jan 6, 2025
@dd-mergequeue dd-mergequeue bot merged commit c672370 into main Jan 6, 2025
228 of 231 checks passed
@dd-mergequeue dd-mergequeue bot deleted the paulcacheux/missing-fs-constants branch January 6, 2025 19:10
@github-actions github-actions bot added this to the 7.63.0 milestone Jan 6, 2025
mwdd146980 pushed a commit that referenced this pull request Jan 10, 2025
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe long review PR is complex, plan time to review it qa/done QA done before merge and regressions are covered by tests team/agent-security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants