Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace API Catalog with Endpoints list #4312

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

brett0000FF
Copy link
Contributor

@brett0000FF brett0000FF commented Jan 22, 2025

What does this PR do?

Motivation:

This change is connected to a soon-to-be-released update where the API Catalog is merged into the Service Catalog.

Change log entry

Additional Notes:

How to test the change?

@brett0000FF brett0000FF requested a review from a team as a code owner January 22, 2025 21:21
Copy link

github-actions bot commented Jan 22, 2025

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-01-22 21:26:49 UTC

@github-actions github-actions bot added the docs Involves documentation label Jan 22, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Jan 22, 2025

Datadog Report

Branch report: brett.blue/api-catalog-migration
Commit report: aeacb09
Test service: dd-trace-rb

✅ 0 Failed, 22090 Passed, 1476 Skipped, 5m 16.79s Total Time

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.71%. Comparing base (fba50ec) to head (aeacb09).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4312   +/-   ##
=======================================
  Coverage   97.71%   97.71%           
=======================================
  Files        1365     1365           
  Lines       82726    82726           
  Branches     4205     4205           
=======================================
+ Hits        80838    80839    +1     
+ Misses       1888     1887    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pr-commenter
Copy link

pr-commenter bot commented Jan 22, 2025

Benchmarks

Benchmark execution time: 2025-01-22 21:43:14

Comparing candidate commit aeacb09 in PR branch brett.blue/api-catalog-migration with baseline commit fba50ec in branch master.

Found 2 performance improvements and 0 performance regressions! Performance is the same for 29 metrics, 2 unstable metrics.

scenario:line instrumentation - targeted

  • 🟩 throughput [+12801.256op/s; +13341.100op/s] or [+8.207%; +8.553%]

scenario:method instrumentation

  • 🟩 throughput [+10632.339op/s; +11311.430op/s] or [+6.379%; +6.786%]

Copy link
Member

@ivoanjo ivoanjo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@ivoanjo ivoanjo merged commit 84ca739 into master Jan 23, 2025
384 checks passed
@ivoanjo ivoanjo deleted the brett.blue/api-catalog-migration branch January 23, 2025 08:44
@github-actions github-actions bot added this to the 2.10.0 milestone Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Involves documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants