API Catalog -> Service Catalog Migration #26763
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddOfir
reviewed
Dec 19, 2024
* removing deprecation message * proposed changes * Fix typo. --------- Co-authored-by: Brett Blue <[email protected]>
brett0000FF
commented
Jan 17, 2025
| @@ -189,7 +189,7 @@ This table shows the mapping between the metric origin as seen in the facet and | |||
|
|
|||
| | Metric Origin | Submitted from | | |||
| | ------------------------| ----------------------------------------------------------------------------- | | |||
| | API Catalog | Timeseries sent by the Datadog [API Catalog][13] product from the APIM Endpoint. | |||
| | API Catalog | Timeseries sent by the Datadog [Service Catalog][13] product from the APIM Endpoint. | |||
There was a problem hiding this comment.
@ddOfir - Note that this is still the text in Demo for the facet:
brett0000FF
added
editorial review
domalessi
reviewed
Jan 23, 2025
|
@brett0000FF Finished my initial review! Calling out that there's some inconsistency re: using API list vs Endpoint list vs Endpoints list, and bolding vs not bolding the term "Endpoint/s". Also made a few suggestions here and there while I was at it (I know a lot of the work was copy/paste but figured I'd correct glaring things if I could). Otherwise, all looks good! |
Co-authored-by: domalessi <[email protected]>
…on into brett.blue/DOCS-9666
domalessi
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do? What is the motivation?
Integrate API Catalog docs into Service Catalog to reflect the new state of the product.
Preview
To do
Consolidate/remove content for API Catalog that's already covered by Service Catalog:
Merge instructions
Merge readiness:
Merge queue is enabled in this repo. To have it automatically merged after it receives the required reviews, create the PR (from a branch that follows the
<yourname>/descriptionnaming convention) and then add the following PR comment:Additional notes