-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create go module for the CRD #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This pull request does not contain a valid label. Please add one of the following labels: bug, enhancement, documentation, tooling
c319b34
to
13fd935
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #196 +/- ##
===========================================
- Coverage 63.10% 43.75% -19.36%
===========================================
Files 41 65 +24
Lines 3098 4939 +1841
===========================================
+ Hits 1955 2161 +206
- Misses 1023 2651 +1628
- Partials 120 127 +7
Flags with carried forward coverage won't be shown. Click here to find out more. see 39 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
|
13fd935
to
7f52c43
Compare
7f52c43
to
c7008b6
Compare
@@ -86,16 +86,16 @@ require ( | |||
go.uber.org/multierr v1.11.0 // indirect | |||
golang.org/x/exp v0.0.0-20230905200255-921286631fa9 // indirect | |||
golang.org/x/mod v0.17.0 // indirect | |||
golang.org/x/net v0.26.0 // indirect | |||
golang.org/x/net v0.28.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Library Vulnerability
golang.org/x/net → 0.28.0
View all suggested fixes
golang.org/x/net v0.28.0 // indirect | |
golang.org/x/net vv0.34.0// indirect |
golang.org/x/net v0.28.0 // indirect | |
golang.org/x/net vv0.33.0// indirect |
Non-linear parsing of case-insensitive content in golang.org/x/net/html (...read more)
An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing. This could cause a denial of service.
github.com/modern-go/reflect2 v1.0.2 // indirect | ||
github.com/pmezard/go-difflib v1.0.1-0.20181226105442-5d4384ee4fb2 // indirect | ||
github.com/x448/float16 v0.8.4 // indirect | ||
golang.org/x/net v0.28.0 // indirect |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔴 Library Vulnerability
golang.org/x/net → 0.28.0
View all suggested fixes
golang.org/x/net v0.28.0 // indirect | |
golang.org/x/net vv0.34.0// indirect |
golang.org/x/net v0.28.0 // indirect | |
golang.org/x/net vv0.33.0// indirect |
Non-linear parsing of case-insensitive content in golang.org/x/net/html (...read more)
An attacker can craft an input to the Parse functions that would be processed non-linearly with respect to its length, resulting in extremely slow parsing. This could cause a denial of service.
.github/workflows/pr-linter.yml
Outdated
@@ -15,7 +15,7 @@ jobs: | |||
- name: Check out code into the Go module directory | |||
uses: actions/checkout@v1 | |||
- name: Verify Pull Request Labels | |||
uses: jesusvasquez333/verify-pr-label-action@v1.1.0 | |||
uses: jesusvasquez333/verify-pr-label-action@v1.4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🟠 Code Vulnerability
Workflow depends on a GitHub actions pinned by tag (...read more)
When using a third party action, one needs to provide its GitHub path (owner/project
) and can eventually pin it to a Git ref (a branch name, a Git tag, or a commit hash).
No pinned Git ref means the action uses the latest commit of the default branch each time it runs, eventually running newer versions of the code that were not audited by Datadog. Specifying a Git tag is better, but since they are not immutable, using a full length hash is recommended to make sure the action content is actually frozen to some reviewed state.
Be careful however, as even pinning an action by hash can be circumvented by attackers still. For instance, if an action relies on a Docker image which is itself not pinned to a digest, it becomes possible to alter its behaviour through the Docker image without actually changing its hash. You can learn more about this kind of attacks in Unpinnable Actions: How Malicious Code Can Sneak into Your GitHub Actions Workflows. Pinning actions by hash is still a good first line of defense against supply chain attacks.
Additionally, pinning by hash or tag means the action won’t benefit from newer version updates if any, including eventual security patches. Make sure to regularly check if newer versions for an action you use are available. For actions coming from a very trustworthy source, it can make sense to use a laxer pinning policy to benefit from updates as soon as possible.
64547e9
to
88b18e9
Compare
Rebased on main |
/merge |
Devflow running:
|
What does this PR do?
Creates a new go module for the CRD.
This will allow other projects like the datadog-operator to rely on that go mod instead of the root go mod of the project.
This will reduce the dependencies required and hopefully create less conflicts when upgrading kubernetes libraries.
Describe your test plan
I don't think there's anything specific apart from verifying that this simplifies the process when we need to upgrade the kubernetes libraries in the datadog-operator.