Release lading 0.23.5 #1090
Merged
Release lading 0.23.5 #1090
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit addresses a bug in the lading target mechanism. In some cases pid 0 would be reported by docker as the pid of the watched container. We also now scope our release down to only the container artifact. Signed-off-by: Brian L. Troutwine <[email protected]>
GeorgeHahn
approved these changes
Nov 4, 2024
blt
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 5, 2024
This commit updates the file_to_blackhole experiments to rely on the lading logrotate FS generator, allowing us to assert on whether the log Agent loses bytes in the course of its operation. I've added a new check asserting that no bytes are lost, although I do not expect this to pass on higher latency intake experiments yet. REF #30744 REF DataDog/lading#1090 Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 5, 2024
This commit updates the file_to_blackhole experiments to rely on the lading logrotate FS generator, allowing us to assert on whether the log Agent loses bytes in the course of its operation. I've added a new check asserting that no bytes are lost, although I do not expect this to pass on higher latency intake experiments yet. REF #30744 REF DataDog/lading#1090 Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 5, 2024
This commit updates the file_to_blackhole experiments to rely on the lading logrotate FS generator, allowing us to assert on whether the log Agent loses bytes in the course of its operation. I've added a new check asserting that no bytes are lost, although I do not expect this to pass on higher latency intake experiments yet. REF #30744 REF DataDog/lading#1090 Signed-off-by: Brian L. Troutwine <[email protected]>
blt
added a commit
to DataDog/datadog-agent
that referenced
this pull request
Nov 6, 2024
This commit updates the file_to_blackhole experiments to rely on the lading logrotate FS generator, allowing us to assert on whether the log Agent loses bytes in the course of its operation. I've added a new check asserting that no bytes are lost, although I do not expect this to pass on higher latency intake experiments yet. REF #30744 REF DataDog/lading#1090 Signed-off-by: Brian L. Troutwine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit addresses a bug in the lading target mechanism. In some cases pid 0 would be reported by docker as the pid of the watched container. We also now scope our release down to only the container artifact.