try to address fixme

DataDog · Nov 25, 2024 · a91fbdf · a91fbdf
1 parent 7d12aca
commit a91fbdf
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/utils/build/docker/nodejs/parametric/server.js b/utils/build/docker/nodejs/parametric/server.js
@@ -207,9 +207,15 @@ app.post('/trace/otel/end_span', (req, res) => {
 });
 
 app.post('/trace/otel/flush', async (req, res) => {
-  await tracerProvider.forceFlush()
-  otelSpans.clear();
-  res.json({ success: true });
+  tracerProvider.forceFlush().then(function() {
+    otelSpans.clear()
+    res.json({ success: true })
+  })
+  .catch(function(rej) {
+    //here when you reject the promise
+    console.log(rej)
+    res.json({ success: false })
+  });
 });
 
 app.post('/trace/otel/is_recording', (req, res) => {

diff --git a/utils/parametric/_library_client.py b/utils/parametric/_library_client.py
@@ -413,8 +413,7 @@ def __exit__(self, exc_type, exc_val, exc_tb):
         # Only attempt a flush if there was no exception raised.
         if exc_type is None:
             self.dd_flush()
-            if self.lang not in ("cpp", "nodejs"):
-                # FIXME(munir): nodejs app does not support calling otel_flush if otel spans are not created 
+            if self.lang != "cpp":
                 # C++ does not have an otel_flush endpoint
                 self.otel_flush(1)