Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escape cells of CSV download #209

Merged
merged 14 commits into from
May 15, 2024
Merged

fix: escape cells of CSV download #209

merged 14 commits into from
May 15, 2024

Conversation

jase88
Copy link
Contributor

@jase88 jase88 commented May 15, 2024 •
edited by tjorbo
Loading

fixes #69

Based on #196

jase88 and others added 14 commits May 8, 2024 14:10
@jase88 @tjorbo
chore(testing): add test target with experimental builder "@angular-d…
14e3381 
…evkit/build-angular:jest"

install jest dependencies and add tsconfig.spec.json
add jest to pipeline runs
@jase88 @tjorbo
fix: import of moment using default import
3949cf0
@jase88 @tjorbo
chore(testing): install jest dependency "jest-environment-jsdom"
8772602
@jase88 @tjorbo
feat(i18n): add localization texts for hardcoded texts
6bd0f6a
@jase88 @tjorbo
feat(csv): add util for escaping csv cells and generating csv file name
e554869
@jase88 @tjorbo
feat(csv): define csv as array of rows and cells and escape every csv…
459b9e2 
… cell
@jase88 @tjorbo
fix(testing): proper test case title
8aedc1d
@jase88 @tjorbo
feat(csv): define csv as array of rows and cells and escape every csv…
dab6b1d 
… cell
@jase88 @tjorbo
fix(testing): proper test case title
930818b
@jase88 @tjorbo
chore(i18n): move localization texts
9d5f817
@jase88 @tjorbo
fix(test): adjust test for localization text
518088f
@jase88 @tjorbo
chore(i18n): show time/date values on platt
7432e0c
@jase88 @tjorbo
ci(testing): fix timezone dependent expected
c576b68
@tjorbo
build: update package-lock.json
b3f4b81
@jase88 jase88 mentioned this pull request May 15, 2024
Closed
@tjorbo tjorbo self-requested a review May 15, 2024 11:37
@tjorbo tjorbo added the bug Something isn't working label May 15, 2024
@tjorbo tjorbo merged commit 801c23d into Dataport:main May 15, 2024
2 checks passed
@tjorbo tjorbo requested review from tjorbo and removed request for tjorbo May 15, 2024 11:42
tjorbo
tjorbo reviewed May 15, 2024
View reviewed changes
Copy link
Member

@tjorbo tjorbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved in #196

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tjorbo tjorbo tjorbo left review comments

Assignees

@jase88 jase88

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Commas in names break the CSV export
2 participants
@jase88 @tjorbo