-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: escape cells of CSV download #196
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @jase88,
Thank you for your PR.
I have reviewed your changes and agree with most of them.
Most of my requested changes are related to translations. Nice idea to translate the csv file as well. But is it possible to move the translation properties so we don't have to add a csvExport property?
Also, I found a serious bug while testing your changes. #203 It is probably not a bug in your code, but if you could do a rebase, it would be clearer which changes are yours. We want to prevent merge commits by rebasing in general. So I will wait with rebasing dependabot's PRs until your PR is done. (To avoid conflicts in package.json)
Thanks again for your contribution.
@jase88 I couldn't rebase the branch onto main because of conflicts. I fixed them by rebasing jase88:main onto terminfinder-frontend:main and rebuilding the package-lock. You can force push this branch to your repo or resolve the conflicts yourself. Thank you for your patience 👍 |
jest
with Angulars experimental builder@angular-devkit/build-angular:jest
jest-preset-angular
(which would add another package and some more configuration files)vitest
via@analogjs/vite-plugin-angular
(which would add a layer ofanalogjs
for testing)fixes #69