Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Quiz component styling + created LessonQuestionsModal & LessonInformationalModal(WIP) #70

Merged
merged 7 commits into from
Jan 17, 2024

Conversation

Markkos89
Copy link
Collaborator

@Markkos89 Markkos89 commented Jan 16, 2024

Changes

  • enhanced Quiz component styling a little bit
  • created new LessonQuestionsModal (cc @recepcankaya sorry for creating it, mate, I hope my code helps in the worst case )
  • Styled old Questions component accordingly based on Quiz component's new design
  • styled the vertical scrollbar according to designs
  • created a LessonInformationalModal to replace the old SideDrawer info use component

Quiz component

before:

Take quiz button to the left
image

General look of Quiz component
image

now:

Take quiz button centered
image

General updated look of Quiz component
image

LessonQuestionsModal

the trigger button looks like this:
image

The modal
image

on mobile:
image

@Markkos89 Markkos89 added the enhancement New feature or request label Jan 16, 2024
@Markkos89 Markkos89 self-assigned this Jan 16, 2024
Copy link

vercel bot commented Jan 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
academy-turbo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 0:33am
academy-turbo-storybook ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 17, 2024 0:33am

Copy link

github-actions bot commented Jan 16, 2024

⚡️ Lighthouse report for the changes in this PR:

Category Score
🔴 Performance 32
🟢 Accessibility 96
🟠 Best practices 75
🟢 SEO 92
🟠 PWA 89

Lighthouse ran on https://academy-turbo-git-feat-quiz-component-styling-developdao.vercel.app/

@Markkos89 Markkos89 changed the title feat: enhanced Quiz component styling a little bit feat: Quiz component styling + created LessonQuestionsModal Jan 16, 2024
@elPiablo
Copy link
Contributor

@Markkos89 the quiz modal looks super smart - the gradient of how the background is hidden is really sexy hehe
and the 'warm-up quiz' modals are also really nice!

Copy link
Contributor

@elPiablo elPiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Markkos89 the quiz modal looks super smart - the gradient of how the background is hidden is really sexy hehe
and the 'warm-up quiz' modals are also really nice! Will we get the background something similar for MVP? i.e. hidden from the learner?
LFG

@Markkos89 Markkos89 changed the title feat: Quiz component styling + created LessonQuestionsModal feat: Quiz component styling + created LessonQuestionsModal & LessonInformationalModal(WIP) Jan 16, 2024
Copy link
Contributor

@elPiablo elPiablo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good @Markkos89 -> let's merge it!!

@Markkos89 Markkos89 merged commit f1ef1a2 into main Jan 17, 2024
@wolovim wolovim deleted the feat/quiz-component-styling branch January 19, 2024 16:33
@wolovim wolovim mentioned this pull request Jan 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants