Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve user messages #77

Merged
merged 8 commits into from
Oct 17, 2024
Merged

Improve user messages #77

merged 8 commits into from
Oct 17, 2024

Conversation

thomasmfish
Copy link
Contributor

@thomasmfish thomasmfish commented Oct 16, 2024 •
edited
Loading

Various changes that allow better messages:

  • Status tracking for reconstruction processes
  • Better exception handling (e.g. only include the traceback when logging unexpected exceptions)
  • Improve behaviour and logging around TIFF combining and writing
  • Raise an exception if rec_array isn't set (shouldn't be possible but sometimes happens) or the array is all NaNs.

@thomasmfish thomasmfish added the enhancement New feature or request label Oct 16, 2024
@thomasmfish thomasmfish self-assigned this Oct 16, 2024
@thomasmfish thomasmfish force-pushed the improve-exception-logging branch 5 times, most recently from f82d81d to 0b08d59 Compare October 16, 2024 18:42
PeterC-DLS
PeterC-DLS reviewed Oct 17, 2024
View reviewed changes
src/sim_recon/images/dataclasses.py Outdated Show resolved Hide resolved
src/sim_recon/recon.py Show resolved Hide resolved
src/sim_recon/recon.py Show resolved Hide resolved
src/sim_recon/recon.py Outdated Show resolved Hide resolved
@thomasmfish thomasmfish force-pushed the improve-exception-logging branch from c752643 to 1a9bdc3 Compare October 17, 2024 10:55
@thomasmfish thomasmfish force-pushed the improve-exception-logging branch from 1a9bdc3 to eddd9dd Compare October 17, 2024 10:58
@thomasmfish thomasmfish merged commit 869e3a0 into main Oct 17, 2024
1 check passed
@thomasmfish thomasmfish deleted the improve-exception-logging branch October 17, 2024 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeterC-DLS PeterC-DLS PeterC-DLS approved these changes

Assignees

@thomasmfish thomasmfish

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasmfish @PeterC-DLS