Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add logs in case data-ingest token is not provided #4089

Merged
merged 4 commits into from
Nov 25, 2024

Conversation

gkrenn
Copy link
Contributor

@gkrenn gkrenn commented Nov 22, 2024

Description

The data-ingest token is propagated to the endpoint-properties file even if the field is empty. To make it easier to debug the issue and tell the user what it could be this PR:

  • Creates and additional log line when the secret is created to inform the user that the token is missing
  • Adds a message to the token condition in the DynaKube to tell if the token was not provided

Jira

How can this be tested?

  • Create a DynaKube with metadata enrichment enabled & data-ingest token missing
  • Check for log line "data ingest token not found in secret" and the token conditions on the DynaKube

@gkrenn gkrenn added the troubleshoot Changes related to logic meant for helping the user to troubleshoot label Nov 22, 2024
@gkrenn gkrenn requested a review from a team as a code owner November 22, 2024 09:57
@gkrenn gkrenn force-pushed the feature/data-ingest-empty-warning branch from df534c5 to 8b6bcde Compare November 22, 2024 13:21
@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.58%. Comparing base (1794e47) to head (88f988f).
Report is 1 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4089      +/-   ##
==========================================
+ Coverage   64.57%   64.58%   +0.01%     
==========================================
  Files         400      400              
  Lines       26773    26784      +11     
==========================================
+ Hits        17288    17299      +11     
  Misses       8128     8128              
  Partials     1357     1357              
Flag Coverage Δ
unittests 64.58% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Collaborator

@wepudt wepudt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gkrenn gkrenn enabled auto-merge (squash) November 25, 2024 13:38
@gkrenn gkrenn merged commit 63b7754 into main Nov 25, 2024
15 checks passed
@gkrenn gkrenn deleted the feature/data-ingest-empty-warning branch November 25, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
troubleshoot Changes related to logic meant for helping the user to troubleshoot
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants