Output the potential phi on the macroparticles #4599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…output_particle_phi
RemiLehe
commented
Apr 8, 2024
| @@ -548,48 +548,6 @@ for (unsigned i = 0, n = particle_diags.size(); i < n; ++i) { | |||
| pinned_pc->make_alike<amrex::PinnedArenaAllocator>() : | |||
| pc->make_alike<amrex::PinnedArenaAllocator>(); | |||
|
|
|||
| // names of amrex::Real and int particle attributes in SoA data | |||
There was a problem hiding this comment.
I had to move this code further down, so that it comes after tmp.AddRealComp("phi");
(This is because the code below reads tmp.getParticleRuntimeComps(); and sets the output flags accordingly.)
RemiLehe
changed the title
RemiLehe
commented
Apr 8, 2024
ax3l
reviewed
Apr 8, 2024
Source/Diagnostics/WarpXOpenPMD.cpp
Outdated
| "Output of the electrostatic potential (phi) on the particles was requested, " | ||
| "but this is only available with `diag_type = Full`."); | ||
| tmp.AddRealComp("phi"); | ||
| tmp.defineAllParticleTiles(); |
There was a problem hiding this comment.
This line should not be needed anymore as of AMReX 24.04 :)
Comment on lines
+592
to
+594
| // Gather the electrostatic potential (phi) on the macroparticles | ||
| if ( particle_diags[i].m_plot_phi ) { | ||
| WARPX_ALWAYS_ASSERT_WITH_MESSAGE( |
There was a problem hiding this comment.
Can you make this if block a function call please so it does separate out nicely and does not make this sub-function longer? I would call it add_phi_component or so and also declare it in ParticleIO.H?
ax3l
added
component: openPMD
RemiLehe
commented
Apr 8, 2024
Co-authored-by: Axel Huebl <[email protected]>
ax3l
reviewed
Apr 8, 2024
| #ifdef AMREX_USE_OMP | ||
| #pragma omp parallel if (amrex::Gpu::notInLaunchRegion()) | ||
| #endif | ||
| for (int lev=0; lev<=warpx.finestLevel(); lev++) { |
There was a problem hiding this comment.
Suggested change
| for (int lev=0; lev<=warpx.finestLevel(); lev++) { | |
| for (int lev=0; lev<=tmp.finestLevel(); lev++) { |
ax3l
reviewed
Apr 8, 2024
| const amrex::Geometry& geom = warpx.Geom(lev); | ||
| auto plo = geom.ProbLoArray(); | ||
| auto dxi = geom.InvCellSizeArray(); | ||
| amrex::MultiFab const& phi = warpx.getField( FieldType::phi_fp, lev, 0 ); |
There was a problem hiding this comment.
For less overhead, we should add a helper that returns an mf on all levels. -> follow-up pr
ax3l
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the option for the user to output the field
phion the macroparticles.The fields are gathered after particles have been filtered for output. As a consequence, the particles are in pinned memory, when the gather kernel is called, which could be slow if this diagnostic is done frequently and/or on a large number of particles.
The automated test looks at the case of an electrostatic sphere exploding under its own space charge (Coulomb explosition). In this process, electrostatic potential energy (space charge) is converted into kinetic energy (explosion velocity). The test uses
phion the particles to compute the potential energy.TODO in follow-up PRs: