Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Output the potential phi on the macroparticles #4599
Output the potential phi on the macroparticles #4599
Changes from 28 commits
96c0643
9670ecc
abc846d
776d106
40d88aa
9e29cf4
c502717
cbe8172
e260a0a
cc9caf7
10cf0fe
d123e91
e0df6e1
288a771
f9f84b5
b429847
8493d01
317aa16
423414e
06dbe71
82181ca
7c3f679
21d8058
3b5b1b7
f540222
b79720d
f977aa6
a918c69
d8ce701
a43a65f
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I had to move this code further down, so that it comes after
tmp.AddRealComp("phi");
(This is because the code below reads
tmp.getParticleRuntimeComps();
and sets the output flags accordingly.)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you make this if block a function call please so it does separate out nicely and does not make this sub-function longer? I would call it
add_phi_component
or so and also declare it inParticleIO.H
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This line should not be needed anymore as of AMReX 24.04 :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For less overhead, we should add a helper that returns an mf on all levels. -> follow-up pr