Feature/multi root trusted ca #923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AssemblyJohn
requested review from
Pietfried,
hikinggrass and
corneliusclaussen
as code owners
james-ctc
approved these changes
Oct 21, 2024
|
Will update the security part based on the comments, make the issues with the remaining fixes (cross, non-self-root), merge and will update the deps here & merge. |
corneliusclaussen
approved these changes
Oct 22, 2024
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/multi_root_trusted_ca
branch
from
2f48af0 to
a108226
Compare
|
Implemented suggestions that could be handled. |
Pietfried
approved these changes
Oct 23, 2024
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/multi_root_trusted_ca
branch
from
d956237 to
61e304d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Introduces one interface API call that allows the retrieval of multiple leaf certificate chains, that are linked to different roots.
Issue ticket number and link
EVerest/libevse-security#91
Checklist before requesting a review