Split OCSP data requests into two separate functions #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est_data and get_ocsp_request_data * implemented both functions according to requirements of Plug&Charge * added LeafCertificate::MO to conversions Signed-off-by: pietfried <[email protected]>
3 tasks
…its valid Signed-off-by: pietfried <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/refactor-get-ocsp-data
branch
from
484b892 to
c2b49ce
Compare
AssemblyJohn
approved these changes
Mar 19, 2024
|
Looks good to me. |
hikinggrass
approved these changes
Mar 19, 2024
3 tasks
AssemblyJohn
force-pushed
the
feature/refactor-get-ocsp-data
branch
from
f3233fe to
263aaff
Compare
Signed-off-by: AssemblyJohn <[email protected]>
AssemblyJohn
force-pushed
the
feature/refactor-get-ocsp-data
branch
from
263aaff to
651ad96
Compare
Pietfried
commented
Mar 20, 2024
Pietfried
commented
Mar 20, 2024
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Co-authored-by: Piet Gömpel <[email protected]> Signed-off-by: John <[email protected]>
Signed-off-by: pietfried <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue ticket number and link
Checklist before requesting a review