-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/get ocsp cache data #64
Conversation
0d3d2b8
to
da844ca
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm except for the OCSP update and retrieval.
My idea would be:
In update_ocsp_cache
we can simply choose a random file name for the OCSP response and store it in some directory that is dedicated for OCSP responses.
For retrieve_ocsp_cache
we should not search for the ocsp response by filename, but rather iterate over the files in the OCSP directory, parse the OCSP data and check if the certificate hash data matches.
What do you think?
I would require some hint in extracting the certificate hash data from the OCSP response. How is that possible? Also it will incur a certain performance cost, since it will imply parsing of all the data all the time, however it seems more stable than the current version. |
I was hoping openssl provides functionality to decode and parse the certificate hash data from the DER encoded ocsp response, but I dont know if that is the case. It would be interesting to know how the OCSP response is loaded during the TLS handshake, because this is our targeted use case. Maybe @james-ctc already has some insights about this? |
Implemented header/interface refactor, request feedback before proceeding. |
There's also a requirement to integrate this with the garbage collection:
|
7a9cf64
to
8b69ebb
Compare
ae5b642
to
4104017
Compare
Comments have been implemented, OCSP relevant test has been implemented. One more test update is required, for garbage collection related to deleted certificates. |
0ecb727
to
77d21e4
Compare
Relevant issues and comments have been solved. |
add1dc1
to
57ba46d
Compare
…hierarchy usage Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
- Refactored get_key_pair for extra info Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
Fixed code for tests Signed-off-by: AssemblyJohn <[email protected]>
Signed-off-by: AssemblyJohn <[email protected]>
d6e71cf
to
5d5a545
Compare
Describe your changes
Issue ticket number and link
EVerest/libocpp#596
Checklist before requesting a review