Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix/66 gracefull crash handling #70

Merged
merged 17 commits into from
May 10, 2024
Merged

Bugfix/66 gracefull crash handling #70

merged 17 commits into from
May 10, 2024

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented May 1, 2024 •
edited
Loading

Describe your changes

Updated the following:

  • generate_csr_interface for clean handling
  • handled some various unhandled errors
  • updated return types
  • removed OpenSSL warnings
  • removed unnecessary test

Issue ticket number and link

#66

Supersedes: #64 as it includes all changes placed there.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@AssemblyJohn AssemblyJohn linked an issue May 1, 2024 that may be closed by this pull request
Gracefull crash handling & interface refactor #66
Closed
@AssemblyJohn AssemblyJohn force-pushed the bugfix/66-gracefull-crash-handling branch from 61bb58d to a207003 Compare May 1, 2024 11:29
AssemblyJohn added 13 commits May 2, 2024 16:54
@AssemblyJohn
Fixed potential bug when writing OCSP cache, switched to certificate …
d555588 
…hierarchy usage

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Added possibility to retrieve OCSP response
e9a30af 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Added utilities for encoding/decoding base64
ce51ca1 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Added test cases
1276fe7 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
- Modified OCSP cache to unique filenames
845d794 
- Refactored get_key_pair for extra info

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Over-write existing OCSP data based on certificate hash
4a62f3c 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Added cleanup for OCSP
75387cd 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Add tests for new OCSP functionality
f06c757 
Fixed code for tests

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Fixes for OCSP data cleanup and test updates
b43b2cd 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Added missing certificate bundle creation exceptions
5972419 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Removed non-necessary RSA7680 key generation tests
ccc1c0d 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Updated some crypto headers and return values and removed openssl war…
85b10f1 
…nings when compiling

Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Interface updates
b56760f 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn AssemblyJohn force-pushed the bugfix/66-gracefull-crash-handling branch from a207003 to b56760f Compare May 2, 2024 13:54
This was referenced May 3, 2024
Merged
Merged
@AssemblyJohn AssemblyJohn force-pushed the bugfix/66-gracefull-crash-handling branch from ed2f85a to 72e0b45 Compare May 6, 2024 08:57
@Pietfried Pietfried self-assigned this May 7, 2024
@AssemblyJohn
Updated docs
f71b51b 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Updated test cases
6e702ef 
Signed-off-by: AssemblyJohn <[email protected]>
Pietfried
Pietfried reviewed May 8, 2024
View reviewed changes
Copy link
Contributor

@Pietfried Pietfried left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, see some comments inline

lib/evse_security/evse_security.cpp Outdated Show resolved Hide resolved
tests/openssl_supplier_test.cpp Show resolved Hide resolved
tests/tests.cpp Outdated Show resolved Hide resolved
@AssemblyJohn
Fixed comments
871ec1e 
Signed-off-by: AssemblyJohn <[email protected]>
@AssemblyJohn
Copy link
Collaborator Author

Update, tested locally, please re-review.

@AssemblyJohn AssemblyJohn requested a review from Pietfried May 8, 2024 13:29
@AssemblyJohn AssemblyJohn merged commit 34ced9f into main May 10, 2024
3 of 4 checks passed
@AssemblyJohn AssemblyJohn deleted the bugfix/66-gracefull-crash-handling branch May 10, 2024 09:21
hikinggrass
hikinggrass reviewed May 10, 2024
View reviewed changes
include/evse_security/evse_security.hpp
@@ -142,6 +142,12 @@ class EvseSecurity {
/// @param ocsp_response the actual OCSP data
void update_ocsp_cache(const CertificateHashData& certificate_hash_data, const std::string& ocsp_response);

// TODO: Switch to path
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this already returns a optional path, is that what this comment meant?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Opps, simply forgot a line.

@AssemblyJohn AssemblyJohn mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hikinggrass hikinggrass hikinggrass left review comments

@Pietfried Pietfried Pietfried approved these changes

Assignees

@Pietfried Pietfried

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gracefull crash handling & interface refactor
3 participants
@AssemblyJohn @hikinggrass @Pietfried