Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple root trusted CA leafs #91

Merged
merged 8 commits into from
Oct 21, 2024
Merged

Multiple root trusted CA leafs #91

merged 8 commits into from
Oct 21, 2024

Conversation

AssemblyJohn
Copy link
Collaborator

@AssemblyJohn AssemblyJohn commented Oct 17, 2024 •
edited
Loading

Describe your changes

Introduces one API call that allows the retrieval of the retrieval of multiple leaf certificate chains, that are linked to different roots.

Issue ticket number and link

Core related branch: https://github.com/EVerest/everest-core/tree/feature/multi_root_trusted_ca

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have made corresponding changes to the documentation
  • I read the contribution documentation and made sure that my changes meet its requirements

@AssemblyJohn AssemblyJohn changed the title Feature/multi root trusted ca Multiple root trusted CA leafs Oct 17, 2024
@AssemblyJohn
Format
f4fb53c 
Signed-off-by: AssemblyJohn <[email protected]>
james-ctc
james-ctc approved these changes Oct 21, 2024
View reviewed changes
Copy link
Collaborator

@james-ctc james-ctc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

recommend documentation updates and review use of std::move

@AssemblyJohn AssemblyJohn mentioned this pull request Oct 21, 2024
Merged
3 tasks
@AssemblyJohn
Copy link
Collaborator Author

Documentation has been updated.

Two additional issues have been created, for the mentioned issues:
#92
#93

@AssemblyJohn AssemblyJohn merged commit 5c0b665 into main Oct 21, 2024
3 of 4 checks passed
@AssemblyJohn AssemblyJohn deleted the feature/multi_root_trusted_ca branch October 22, 2024 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@james-ctc james-ctc james-ctc approved these changes

@Pietfried Pietfried Awaiting requested review from Pietfried Pietfried is a code owner

@hikinggrass hikinggrass Awaiting requested review from hikinggrass hikinggrass is a code owner

Assignees

@james-ctc james-ctc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AssemblyJohn @james-ctc