-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[chore] Ignore vulnerability in DependencyCheck and bumped the version #286
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still failing with Github Actions though
f94b1ed
to
544d84d
Compare
9460f6c
to
f102f29
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't love this particular solution. Let's chat internally about this. I feel it defeats the point of having a dependency manager if we just store local copies of the dependencies. Dependencies typically shouldn't be checked into a repo if we can help it since it's not our code and will make future diffs bigger than they should be.
706c20e
to
d466f09
Compare
ba15af6
to
1f07335
Compare
1f07335
to
8809310
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks in line with what Justin was asking
Description
The DependencyCheck plugin we use to scan for vulnerabilities in our library is, itself, vulnerable. This is a red herring that unfortunately causes our CI to fail.
This PR will ignore this known vulnerability for the time being.
This does NOT pass vulnerable code down to our end-users, as this is purely an issue with one of the plugins we use to test the library.
Testing
make scan
calls dependency check as expectedPull Request Type
Please select the option(s) that are relevant to this PR.