Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FKED-90: Add support for deleting experiences 💥 #35

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

techninja
Copy link
Member

@techninja techninja commented Nov 29, 2018

FKED-90: As a user I'd like to delete experiences

This PR does the following:

  • Adds a new UI button on the experience
  • Adds a new action, API method, and reducer for removing experiences

To Review:

  • Checkout this branch.
  • Run yarn start.
  • Login, and on the central dashboard, create a new experience (to be deleted momentarily).
  • See that your new experience is listed with the rest of your experiences, and that each has a new "delete" button listed with helpful hover text
  • Click the delete button on the new experience, and see that you are presented with a modal warning dialog that you must accept.
  • Click cancel to see that the experience is untouched.
  • Click delete again and after clicking OK, see that the experience is removed from the list.
  • Refresh the page and see the deleted experience is truly removed from server fetches

@techninja techninja added the ready for review This PR is ready to be reviewed. label Nov 29, 2018
@patrickocoffeyo patrickocoffeyo added the passes code review The code in this PR passes review. label Nov 30, 2018
@patrickocoffeyo
Copy link
Member

@techninja this code looks good. Will do a functional pass when I get a chance to boot into Windows :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
passes code review The code in this PR passes review. ready for review This PR is ready to be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants