fix: allow offline init with unobfuscated config #143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
typotter
commented
Dec 20, 2024
aarsilv
approved these changes
Dec 20, 2024
| @@ -175,13 +175,13 @@ public Builder assignmentCache(IAssignmentCache assignmentCache) { | |||
| public Builder initialConfiguration(byte[] initialFlagConfigResponse) { | |||
| this.initialConfiguration = | |||
| CompletableFuture.completedFuture( | |||
| Configuration.builder(initialFlagConfigResponse, true).build()); | |||
| new Configuration.Builder(initialFlagConfigResponse).build()); | |||
There was a problem hiding this comment.
Nice! By omitting it will parse the flag response and then check the format field 🚀
typotter
deleted the
typo/ff-3751-android-sdk-ability-to-use-unobfuscated-initial
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: FF-3751
Motivation and Context
Due to the sensitive nature of the client configuration payload, the decision was made to support only obfuscated configuration in the Android SDK through its standard initialization method. This decision was made prior to the introduction of the
formatfield inFlagConfigResponse. This was short-sighted asformatfield which can be used to determine the format of the configuration.Changes
Configuration.Builderwithout forcingisConfigObfuscatedtotrueFuture work
isConfigObfuscatedcan be provided in the jvm-common-sdk